Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 Reorienting screen can put sim in corner #65

Closed
KatieWoe opened this issue Aug 22, 2019 · 13 comments
Closed

iOS 13 Reorienting screen can put sim in corner #65

KatieWoe opened this issue Aug 22, 2019 · 13 comments
Assignees
Labels

Comments

@KatieWoe
Copy link

Found when looking at #64.
If you start a sim in portrait, move to landscape, and then move back to portrait, the sim will shift to take up only the upper left corner of the screen. You must be out of full screen to achieve this, but once you have, full screen will show the bug as well.
Image from iOS (1)
Image from iOS

@ariel-phet
Copy link

https://www.youtube.com/watch?v=NyC--vsiGEI

@ariel-phet
Copy link

@jonathanolson said today he will investigate while he has the iOS 13 iPad

@jonathanolson
Copy link
Contributor

Should be fixed in master (as part of the commit for #64), can you verify?

@KatieWoe
Copy link
Author

KatieWoe commented Sep 5, 2019

Looks good on master. Checked two different sims

@KatieWoe KatieWoe assigned jonathanolson and unassigned KatieWoe Sep 5, 2019
@KatieWoe
Copy link
Author

For phetsims/qa#427. If you have the sim in portrait. Lock the iPad by pressing the upper right button, and then unlock it, the sim will be in the corner. If you reorient it fixes itself.

@jonathanolson
Copy link
Contributor

For phetsims/qa#427. If you have the sim in portrait. Lock the iPad by pressing the upper right button, and then unlock it, the sim will be in the corner. If you reorient it fixes itself.

This does look like an issue, however iPadOS is reporting the incorrect window.innerWidth and window.innerHeight, so it's not just an event listener that would be needed. I haven't figured out a workaround yet.

@jonathanolson
Copy link
Contributor

I haven't found a working work-around for this. We properly receive the events that the sim has resized, but we're being given buggy information (even after), so I'm somewhat at a loss of how to fix it besides submitting a bug report.

@jonathanolson
Copy link
Contributor

I can't reproduce this on my iPhone. Can we verify if this is a problem on the live 13.1 iPadOS?

@KatieWoe
Copy link
Author

KatieWoe commented Oct 2, 2019

It does happen on the live iPadOS. Can confirm that it is not an issue on iPhone

@KatieWoe KatieWoe assigned jonathanolson and unassigned KatieWoe Oct 2, 2019
@jonathanolson
Copy link
Contributor

I can look into potential workarounds (that might not be pretty or performant at all), but I can't see any other avenues besides that or "wait for Apple to fix it". @ariel-phet thoughts?

@jonathanolson jonathanolson removed their assignment Oct 2, 2019
@samreid
Copy link
Member

samreid commented Oct 3, 2019

Have we given Apple a self-contained reproducible example and bug report?

@jonathanolson
Copy link
Contributor

Not for this issue yet.

@ariel-phet
Copy link

Considering @KatieWoe comment #65 (comment) this now seems like a less likely use case, and reorienting fixes the condition. Closing since does not seem realistic/worth fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants