Skip to content

Commit

Permalink
Enable rule @typescript-eslint/explicit-module-boundary-types, see ph…
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Aug 8, 2022
1 parent 7c2da46 commit 4c00e2a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions js/OrientationPair.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ class OrientationPair<T> extends EnumerationMap<Orientation, T> {
return this.get( Orientation.HORIZONTAL );
}

public set horizontal( value ) {
public set horizontal( value: T ) {
this.set( Orientation.HORIZONTAL, value );
}

public get vertical(): T {
return this.get( Orientation.VERTICAL );
}

public set vertical( value ) {
public set vertical( value: T ) {
this.set( Orientation.VERTICAL, value );
}

Expand Down
2 changes: 1 addition & 1 deletion js/memoize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import phetCore from './phetCore.js';
* @param func - Should take one argument
* @returns - Returns a function that is equivalent, but caches values from previous keys
*/
function memoize<Key, Value>( func: ( k: Key ) => Value ) {
function memoize<Key, Value>( func: ( k: Key ) => Value ): ( k: Key ) => Value {
const map = new Map<Key, Value>();

return ( key: Key ): Value => {
Expand Down
2 changes: 1 addition & 1 deletion js/merge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function merge<A, B, C, D, E>( a: A, b: B, c: C, d: D, e: E ): A & B & C & D & E
* @param {Object} target - the object literal that will have keys set to it
* @param {...<Object|null>} sources
*/
function merge( target: IntentionalAny, ...sources: IntentionalAny[] ) { // eslint-disable-line no-redeclare
function merge( target: IntentionalAny, ...sources: IntentionalAny[] ): IntentionalAny { // eslint-disable-line no-redeclare
assert && assertIsMergeable( target );
assert && assert( target !== null, 'target should not be null' ); // assertIsMergeable supports null
assert && assert( sources.length > 0, 'at least one source expected' );
Expand Down

0 comments on commit 4c00e2a

Please sign in to comment.