Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading Studio with some nonexistent locales results in assertion errors #281

Closed
Tracked by #896
, #897
...
zepumph opened this issue Feb 1, 2023 · 2 comments
Closed
Tracked by #896
, #897
...

Loading Studio with some nonexistent locales results in assertion errors #281

zepumph opened this issue Feb 1, 2023 · 2 comments
Labels
status:blocks-sim-publication status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Feb 1, 2023

Bug reported in phetsims/beers-law-lab#320 and should block ph-scale as well, since it was noted that it occurs in the 1.6.0-rc.2 ph-scale version.
@zepumph
Copy link
Member Author

zepumph commented Feb 1, 2023

To cherry pick: phetsims/joist@4889cfb

@samreid samreid mentioned this issue Feb 1, 2023
Closed
matthew-blackman pushed a commit that referenced this issue Feb 3, 2023
@UniverseAndMore
updated dependencies to fix studio locale query parameter, see - #281
3ae5758
matthew-blackman pushed a commit to phetsims/ph-scale-basics that referenced this issue Feb 3, 2023
@UniverseAndMore
updated dependencies to fix studio locale query parameter, see - phet…
438ecba 
…sims/ph-scale#281
This was referenced Feb 3, 2023
Closed
Closed
@Nancy-Salpepi
Copy link

This looks good in rc.3 for pH Scale and pH scale Basics. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:blocks-sim-publication status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zepumph @Nancy-Salpepi @matthew-blackman