Publish 1.6.0-rc.2 (basics too)

[zepumph]

Parent issue: #236 and phetsims/ph-scale-basics#51

Rc.1 testing issue: phetsims/qa#872 and phetsims/qa#873

@samreid and I fixed many parts of the PhET-iO infrastructure (mostly migration-related) during this release. We will now bring the changes over to the branches.

We went through all issues marked as needing to be in the branches, and came up with this list. Note the vast majority are in phet-io-wrappers and phet-io-sim-specific, as migration-related:

#266-https://github.com/phetsims/scenery/commit/6fe6985dd8b36346f224ee500f9cf1699f53f049

#267-https://github.com/phetsims/phet-io-sim-specific/commit/99215da33b4f4ca571d90c74d1d665a5b2572780
#267-https://github.com/phetsims/phet-io-sim-specific/commit/a049148bf41fa23eb16c08c6021bc114ac87dbf2
#267-https://github.com/phetsims/phet-io-wrappers/commit/3074c157e35524cb1d3d0ce8e06e5127151c1d98
#267-https://github.com/phetsims/phet-io-wrappers/commit/43fd682d9270cf74eb03db8cd84dc5fbceb69e84

#268-https://github.com/phetsims/phet-io-sim-specific/commit/fc3719921a606d45692ddada930da801ea6081c0
#268-https://github.com/phetsims/phet-io/commit/b603cd2fd73b77cde57542e00980a00953fc68f5
#268-https://github.com/phetsims/phet-io-wrappers/commit/708869e7fef07c6840e68db46317404ae5728129
#268-https://github.com/phetsims/phet-io/commit/daec3519949e0d17ced6c0c56b86b15d0a5f7b95
#268-https://github.com/phetsims/phet-io-sim-specific/commit/8f78b39c4eee333f2c2b3d366989188240e1d6f9
#268-https://github.com/phetsims/phet-io/commit/785952ddf35fea28474ee81a72d50a160c23adae
#268-https://github.com/phetsims/tandem/commit/c874de51c8341db5d5161d4e6a6c61d089535343
#268-https://github.com/phetsims/phet-io-wrappers/commit/41c3cc1ffbcff7c0fc0290ecae7455a87003f518
#268-https://github.com/phetsims/phet-io-sim-specific/commit/9b6efe7b54ff0ed3a8a16daa9e88bfff0d8ccb98
#268-https://github.com/phetsims/phet-io-sim-specific/commit/db6b40c10c347ce0e741837b4fe6141aae6c4051
#268-https://github.com/phetsims/phet-io-sim-specific/commit/8804ecced564ce51c01821151f387f6bc4f3234f
#268-https://github.com/phetsims/phet-io-sim-specific/commit/6048e1cb24ab8a55ef4f1ec8054f0e1cf1f77366
#268-https://github.com/phetsims/phet-io/commit/cebe15f2802e91460d80058441fd17b9c4a564a4
#268-https://github.com/phetsims/phet-io/commit/9bb5bd062a5793b417a7fe6b11dbffc5b6220174
#268-https://github.com/phetsims/phet-io/commit/b9338adfb39dd7d8a1785f1002997852ac0f0bc1

#269-https://github.com/phetsims/phet-io-wrappers/commit/29fd75d0f9586f9415bd14e81b912203752326e8
#269-https://github.com/phetsims/phet-io-wrappers/commit/398c90d6bf191ae8e7e964b2f774e4a607d8ad08
#269-https://github.com/phetsims/phet-io-sim-specific/commit/ab67e5e20d2d5b97d082c1c52dacdde0acf24c58
#269-https://github.com/phetsims/phet-io-wrappers/commit/7919a5e5982ccf21a40cfb51b458ed1160b3cb0e
#269-https://github.com/phetsims/phet-io-wrappers/commit/6879431ec762dae5df77196c9bf0c9e3e3fcce33
#269-https://github.com/phetsims/phet-io-wrappers/commit/21c6b05575d095565f2f832ab427a0f8946c45e6
#269-https://github.com/phetsims/chipper/commit/2fa6264ecc5f095d55619025383e6279232363c6
#269-https://github.com/phetsims/phet-io-sim-specific/commit/45af541aa8074260b796dc0d148387032baec4a1
#269-https://github.com/phetsims/tandem/commit/0d2f3715eda13296c456ea2dbb6b994dd9bada0e
#269-https://github.com/phetsims/phet-io-wrappers/commit/76de6535330d439794d056d66a9df7e8e0c4f923
#269-https://github.com/phetsims/phet-io-sim-specific/commit/fbae119fe49f3fef4191da1aef6e3c9eb69c3c79
#269-https://github.com/phetsims/phet-io/commit/9bb5bd062a5793b417a7fe6b11dbffc5b6220174
#269-https://github.com/phetsims/phet-io-wrappers/commit/181070ceb0b5f57bdb9f2054b516db44ca690826
#269-https://github.com/phetsims/phet-io-wrappers/commit/5594f2c36fa8802805a6fb486623776a1040ec04
#269-https://github.com/phetsims/phet-io-sim-specific/commit/592a8e557e99b2e445705125e951e82bea2805a7
#269-https://github.com/phetsims/phet-io-sim-specific/commit/40459e2969d75ac326ddc8c3d359aeb27429504f
#269-https://github.com/phetsims/phet-io-wrappers/commit/6533a4c9968c1cab06221cbd5b904162cad8d65d
#269-https://github.com/phetsims/chipper/commit/b2c0051df77b832fe110d15865714e00bf10b563
#269-https://github.com/phetsims/tandem/commit/3976db7a368cca0d06f02c9146145c76894d369a

#270-https://github.com/phetsims/ph-scale/commit/2729be585989b24df02b2869787f464c7c295028
#270-https://github.com/phetsims/phet-io-sim-specific/commit/6a448c906f9c3205dc63c2220dc2d06ff177ad43

#273-https://github.com/phetsims/phet-io-sim-specific/commit/3c4c7577ad85b42d831309472bffee78a4882555
#273-https://github.com/phetsims/phet-io-sim-specific/commit/f18cc3eaf253ff5b5a4d76e17ac7c14087254c4d
#273-https://github.com/phetsims/phet-io-sim-specific/commit/935423ff76f73eb2e155fae38b35b2775baa3161
#273-https://github.com/phetsims/chipper/commit/ec2ff69ca00f53f50160449361858fc435fe8d9d
#273-https://github.com/phetsims/phet-io-sim-specific/commit/2f3a8acb1982e6b61dab1efd53ca3186a1ca18eb
#273-https://github.com/phetsims/phet-io-sim-specific/commit/47e08f10cbc80e7cb7f617c920366d3f0d1780e1
#273-https://github.com/phetsims/chipper/commit/383df43b1c73e8470582dbb182a656288541b900

#274-https://github.com/phetsims/phet-io-wrappers/commit/84da4632b21a7163b3e7922604d2ced29b5d4133

#275-https://github.com/phetsims/phet-io-wrappers/commit/a29a2e1dc36f6e822fb5e8d4791ed5c744cea884
#275-https://github.com/phetsims/studio/commit/228a5eed98bb1a2661851876651d6098bec531e8
#275-https://github.com/phetsims/studio/commit/19491e1ac03aa486ee923b32424a865eb2547088
#275-https://github.com/phetsims/phet-io-wrappers/commit/02927c9dfffa0b48e26a7b65d70fb07599159ab0
#275-https://github.com/phetsims/phet-io-wrappers/commit/ea307088e4a2e67dae60a9294fc5b5219432c5de
#275-https://github.com/phetsims/studio/commit/339637b3fb313865510b175e0d1efba4a097ece1
#275-https://github.com/phetsims/phet-io-wrappers/commit/001c35b87aae8968b1639c4199fb25c7b1378204
#275-https://github.com/phetsims/phet-io-wrappers/commit/7bf3e774d820369cd0c2729c0ea0a0b53520b838
#275-https://github.com/phetsims/perennial/commit/9a90f575ff2ce15f4190f10f94149621653dc49b
#275-https://github.com/phetsims/phet-io-wrappers/commit/b7783f80fb0c4fb58fc3bad74d11ff4086bd0a1a
#275-https://github.com/phetsims/phet-io-wrappers/commit/acc44e35ee19ee77912c44978358c4d8bbc14872
#275-https://github.com/phetsims/phet-io-wrappers/commit/11c46bd47d74931c5b9f69baee5154ca9426c572

#276-https://github.com/phetsims/phet-core/commit/ee0545a7ebede234990e529d6322d9c934b1c098

#278-https://github.com/phetsims/phet-io-sim-specific/commit/397edef03590deae9f893615d541c4f61547142a
#278-https://github.com/phetsims/phet-io-sim-specific/commit/006f4e0e153980182a2053e3c0ec7f86ec88e6b1
#278-https://github.com/phetsims/phet-io-wrappers/commit/d73c216aa2d7f767521c2722b92863e37d1730b0

#279-https://github.com/phetsims/tandem/commit/4a12acf903b00e5b5647e902171949617b9e5f1b
#279-https://github.com/phetsims/phet-io-sim-specific/commit/31273fccbc9a62042420e6e1d83e63d960510f3e
#279-https://github.com/phetsims/scenery/commit/907d4c40db81f9ce634542ce4ca253301ca4dede
#279-https://github.com/phetsims/phet-io-wrappers/commit/d7cf4f57506ab5f03739796bbc813433db087def
#279-https://github.com/phetsims/phet-io-sim-specific/commit/2144550d116be71d8d8e7a5f2d1e137b456e4d18
#279-https://github.com/phetsims/phet-io-sim-specific/commit/dd82e7709eca27d13debbd4894ebdf40dcd59205
#279-https://github.com/phetsims/phet-io-wrappers/commit/831c7320bceaf40903d576c6466e0a6e14eb5e73

BASICS:
#53-https://github.com/phetsims/phet-io-sim-specific/commit/3bc009e5f4fc56b48096a150636a8300c65c0527

#56-https://github.com/phetsims/phet-io-sim-specific/commit/5f7deb1fde7b6456a05f698adcf33302d3cf9780
#56-https://github.com/phetsims/phet-io-sim-specific/commit/c46c3b489a6495e0789881483cc5b0b8b9856cf1
#56-https://github.com/phetsims/phet-io-sim-specific/commit/4a3955fc2b796808856c709e494808d0a2927479

To make sure not to forget:

• We will take master for phet-io-sim-specific, because the only difference between master and the tip of the ph-scale branch are regenerations of the PhET-iO API. We will make sure to regenerate the API files and diff them with master to make sure we didn't miss anything.
• We will take master for phet-io-wrappers and phet-io because the only difference between master and 1.6 branches are the commits listed above AND one copyright update :)
• Then look at the important repos for all commits
• On each branch, regenerate phet-io api
• In chipper, we saw this commit after shaws were created, let's double check that ga4 stuff is good to go on the ph-scale shas. phetsims/chipper@5af67e4. UPDATE: We see JO commits on ph-scale(-basics) for GA updates linking to (Sims) Internal GTM and external GTAG/GA4 tracking via query parameters phetcommon#60. All good.

[zepumph]

@samreid and I have:

• Cherry picked all needed changes onto ph-scale-1.6 branches.
• Confirmed that all bugs are fixed in locale unbuilt/built versions
• Gone through each issue in ph-scale and ph-scale-basics repos and confirmed fixed in local copy of ph-scale.
• Directly copied ph-scale's dependencies into ph-scale-basics to keep things in sync.
• Tested all issues in ph-scale-basics locally to ensure fixed.
• Deleted all ph-scale-basics-1.6 branches, and instead directly used the SHA that ph-scale used.

We are now ready to make RCs, confirm fixes in the actual versions, and proceed with test issues.

[zepumph]

Links have been published:
https://phet-dev.colorado.edu/html/ph-scale-basics/1.6.0-rc.2/phet-io/
https://phet-dev.colorado.edu/html/ph-scale/1.6.0-rc.2/phet-io/

[zepumph]

QA issues will follow, but I can't do it tonight.

There are 6 issues labelled "ready-for-review" that QA can close upon verification:
#275
#274
#271
#270
#269
#267

For the QA issues:

• give links to the version migration wrapper
• post these issues
• Note that ph-scale-basics is a true subset of ph-scale (besides migration), and that most testing can be done in ph-scale
• Make sure there is an added "special instruction" about testing the migration code substantially.

In my opinion. This is not a full RC. The SHAs that have been added to these branches were plentiful, but the vast majority of them (more than 55/75) had to do with migration. I think there is good reason to call this a spot check, especially since one of the linked issues above asks QA to take a dive into migration with our new tool. Let's touch base next week before making issues.

[zepumph]

RC test issues have been created. Closing