-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise screenshots #256
Comments
I guess another questions is: Is it worth the effort to revise the screenshots, or are the current screenshots good enough? |
The Preferences button is only present when running the all.html file (ph-scale_all_phet.html, ph-scale-basics_all_phet.html), so it probably should not be in the screenshots. But I'm not sure... |
We don't necessarily update sim screenshots when there are only minor changes to the navbar (like adding a single button). However, there have been lots of changes to the navbar: menu dots, home button size and placement, preferences button, and the size of the PhET logo. I think it's worthwhile to update the screenshots, so I'll take care of that.
That's an interesting point, and I don't think we have an established pattern here. Since the goal is to eventually serve the _all file on the sim page, I think it's okay for the Preference button to be visible in the screenshots. |
So.... Since it sounds like we want to update the screenshots for 1.6 publication, I'll label this as blocks-sim-publication. |
Screenshots for ph-scale and ph-scale-basics updated in the above commits. I created an alt3 for ph-scale because the previous screenshots used for the website did not feature the Macro screen at all. I took the screenshots from master to pick up the dashed line in the pH meter #262, but forgot to use |
Agreed! |
Noted after creating a dev version for #236 ...
The .png files published with the sim do not match current reality. For example:
ph-scale-io.png:
actual sim:
Note the navigation bar. The Home button is in a different place, and a different size. The Preferences button is missing.
These .png files are generated from assets/*screenshots.png. So I'm guessing that all of the screenshots in ph-scale/assets/ and ph-scale-basics/assets need a refresh.
@arouinfar can you do this?
The text was updated successfully, but these errors were encountered: