Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise screenshots #256

Closed
pixelzoom opened this issue Dec 15, 2022 · 6 comments
Closed

Revise screenshots #256

pixelzoom opened this issue Dec 15, 2022 · 6 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 15, 2022

Noted after creating a dev version for #236 ...

The .png files published with the sim do not match current reality. For example:

ph-scale-io.png:

ph-scale-ios

actual sim:

screenshot_2068

Note the navigation bar. The Home button is in a different place, and a different size. The Preferences button is missing.

These .png files are generated from assets/*screenshots.png. So I'm guessing that all of the screenshots in ph-scale/assets/ and ph-scale-basics/assets need a refresh.

@arouinfar can you do this?

@pixelzoom
Copy link
Contributor Author

I guess another questions is: Is it worth the effort to revise the screenshots, or are the current screenshots good enough?

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Dec 15, 2022

The Preferences button is missing.

The Preferences button is only present when running the all.html file (ph-scale_all_phet.html, ph-scale-basics_all_phet.html), so it probably should not be in the screenshots. But I'm not sure...

@arouinfar
Copy link
Contributor

arouinfar commented Dec 15, 2022

We don't necessarily update sim screenshots when there are only minor changes to the navbar (like adding a single button). However, there have been lots of changes to the navbar: menu dots, home button size and placement, preferences button, and the size of the PhET logo. I think it's worthwhile to update the screenshots, so I'll take care of that.

The Preferences button is only present when running the all.html file (ph-scale_all_phet.html, ph-scale-basics_all_phet.html), so it probably should not be in the screenshots. But I'm not sure...

That's an interesting point, and I don't think we have an established pattern here. Since the goal is to eventually serve the _all file on the sim page, I think it's okay for the Preference button to be visible in the screenshots.

@pixelzoom
Copy link
Contributor Author

So.... Since it sounds like we want to update the screenshots for 1.6 publication, I'll label this as blocks-sim-publication.

arouinfar added a commit that referenced this issue Dec 21, 2022
arouinfar added a commit to phetsims/ph-scale-basics that referenced this issue Dec 21, 2022
@arouinfar
Copy link
Contributor

Screenshots for ph-scale and ph-scale-basics updated in the above commits. I created an alt3 for ph-scale because the previous screenshots used for the website did not feature the Macro screen at all. I took the screenshots from master to pick up the dashed line in the pH meter #262, but forgot to use locales so there's no preferences button. I don't think the button is important enough to re-take all 10 screenshots (main, alts, and screen-specific for the eventual metadata service hook-up), so I'll go ahead and close.

@pixelzoom
Copy link
Contributor Author

I don't think the button is important enough to re-take all 10 screenshots

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants