-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for standard UI sounds #248
Comments
Standard UI sounds have been added. @arouinfar please review in master. |
Thanks @pixelzoom. The standard UI sounds all appear as expected.
I'll note that pH Scale: Basics feels a bit odd with just the current UI sounds. The sim has only 6 interactive elements, and of those, only the solute ComboBox and the ResetAllButton have any sound. Since we are working on the alt input patterns for the momentary button (dropper) and FaucetNode, I wonder if we should consider spending time on UI sounds for those components too. Leaving open and self-assigned to discuss during quarterly planning. |
I very much agree. And I feel the same way about the first (Macro) screen of pH Scale, not just Basics. In general, I haven't had a good feeling about adding UI sound to sims where the majority of interaction is with non-standard UI components that have no sound. It's a very odd user experience. |
Noted. Sounds like a good thing to discuss re UI sounds. Let's connect with @Ashton-Morris and @jbphet. Could adding some sounds to these kinds of UI elements be part of the upcoming sprint week along with the alt-input work? Momentary button seems reusable? |
No problem for me doing so if that's the priority. |
In Slack, @kathy-phet wrote:
So I've disabled sound by removing `"supportsSound": true" from package.json for ph-scale and ph-scale-basics. Unassigning this issue and labeling as deferred, to be addressed sometime after 1.6 PhET-iO release. |
Since we are proceeding with completion of alt input in #249, it seems appropriate to also revisit UI sound. Comparing to the state of sound back in 10/2022 (see @arouinfar summary in #248 (comment)) we now have default sounds for the draggable items (pH probe, chart "indicators") and the faucet. So the sound implementation does feel more complete now. Sound needs to be addressed for the momentary toggle button on the dropper -- in common code, and requires both design input and a bit of implementation. See phetsims/sun#895 and phetsims/sun#896. @arouinfar @kathy-phet Your thoughts? |
@kathy-phet requested that I add support for UI sound (the standard common-code sounds) to ph-scale and ph-scale-basics. There will be no custom sounds or sound design.
The text was updated successfully, but these errors were encountered: