Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are Solute instances of phetioType ObjectIO? #247

Closed
zepumph opened this issue Sep 12, 2022 · 3 comments
Closed

Why are Solute instances of phetioType ObjectIO? #247

zepumph opened this issue Sep 12, 2022 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Sep 12, 2022

We are passing Solute.SoluteIO in as a phetioType, so I would have thought that would be the phetioType. Discovered while investigating #243.

SOLUTION:

Ahhh, because all solutes are static instances, and so is the IOType. We need to create the IOType before the other statics. Commit coming soon.

zepumph added a commit that referenced this issue Sep 12, 2022
@zepumph
Copy link
Member Author

zepumph commented Sep 12, 2022

@pixelzoom, this was my confusion over in (2) of #243 (comment). Note now how you can see the ph of the Solute in something like phScale.global.model.solutes.blood in studio as an "initial value". Please review.

@pixelzoom
Copy link
Contributor

Thanks. Good to know that TS is just as stupid as JS when it comes to static definitions. I'll need to apply this to other sims too.

@zepumph
Copy link
Member Author

zepumph commented Sep 13, 2022

It is worth tagging @samreid just to make sure that he sees 734e5ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants