-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Solute link to nameProperty #246
Comments
Before I actually do this, since it will be an API change... In #243, recall that we removed 'name' from SoluteIO, because it's now dynamic. Would you like each Solute's Here's how the the Studio tree currently looks. The addition would be a |
Great question @pixelzoom. If I remember correctly, |
Done in the above commit, for ph-scale and ph-scale-basics. Screenshot below shows the ph-scale-basics Studio tree. @arouinfar please review. Feel free to close. |
…mboBox, clean up SolutionPanel, phetsims/ph-scale#246
Looks good, thanks @pixelzoom! |
Related to #243 ...
We removed
name
from SoluteIO because name is now dynamic, a Property, and as @samreid said in #243 (comment):So when phetsims/axon#414 has been addressed, I will link Solute to its
nameProperty
.The text was updated successfully, but these errors were encountered: