Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QA credits for 1.6 release. #237

Closed
pixelzoom opened this issue Jul 13, 2022 · 4 comments
Closed

Update QA credits for 1.6 release. #237

pixelzoom opened this issue Jul 13, 2022 · 4 comments
Labels
status:blocks-sim-publication

Comments

@pixelzoom
Copy link
Contributor

Update QA credits for 1.6 release.

Credits are shared with ph-scale-basics via PHScaleConstants.CREDITS.
@samreid
Copy link
Member

samreid commented Dec 3, 2022

@KatieWoe can you please advise what the QA credits would be for this sim, if it went into testing in the next several business days?

@pixelzoom
Copy link
Contributor Author

@samreid QA credits are not revised before testing, because there's no way to know for certian who will be involved. They are revised during testing, and often after the final RC test, to reflect who actually worked on QA for the sim. So there's no need for @KatieWoe to answer this question yet, and I'll be tracking it as the sim moves through the QA process.

@samreid
Copy link
Member

samreid commented Dec 3, 2022

Good to know, thanks!

matthew-blackman pushed a commit that referenced this issue Feb 7, 2023
@UniverseAndMore
Update QA credits - see #237
0773a72
matthew-blackman pushed a commit that referenced this issue Feb 7, 2023
@UniverseAndMore
Update QA credits - see #237
bc3a1ef 
(cherry picked from commit 0773a72)
samreid pushed a commit that referenced this issue Feb 7, 2023
@UniverseAndMore @samreid
Update QA credits - see #237
c68be84 
(cherry picked from commit 0773a72)
samreid added a commit to phetsims/ph-scale-basics that referenced this issue Feb 7, 2023
@samreid
Update dependencies.json with fixes for phetsims/ph-scale#237 and phe…
57b3fef 
…tsims/ph-scale#274
@samreid
Copy link
Member

samreid commented Feb 7, 2023

We got the credits from @Nancy-Salpepi, cherry picked into ph-scale and basics. Checked in RC and double checked in published version. Closing.

@samreid samreid closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:blocks-sim-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @pixelzoom @KatieWoe