PhET-iO API error when using 'screens' query parameter

[pixelzoom]

See phetsims/tandem#194. No idea if I need to address this for ph-scale RC.

[pixelzoom]

This apparently does need to be addressed for RC.

[pixelzoom]

phetsims/tandem#194 has been addressed and verified in master. But I've hit a merge conflict trying to cherry-pick the changes, see phetsims/tandem#194 (comment). I'll need assistance from @zepumph.

[pixelzoom]

@zepumph provide details on how to resolve merge conflicts in phetsims/tandem#194 (comment), so I'll try again.

[pixelzoom]

I resolved the merge conflict in phetioApiValidation.js by changing this:

    this.enabled = assert &&
                   Tandem.VALIDATION &&
                   phet.chipper.queryParameters.screens === null &&
                   phet.chipper.queryParameters.homeScreen;

... to this:

    this.enabled = assert &&
                   Tandem. PHET_IO_ENABLED &&
                   phet.chipper.queryParameters.screens === null &&
                   phet.chipper.queryParameters.homeScreen;

Seems to work OK in ph-scale 1.4 and ph-scale-basics-1.4, but makes me nervous to be doing partial cherry-picks.

Ready for testing in next RC.

[pixelzoom]

This is irrelevant for ph-scale-basics.

To verify in the next ph-scale RC:

1. Run the sim in Studio with ?screens=1
2. Verify that the sim is run with the first screen only.
3. Verify that there are no errors in the console.

It is expected that all 3 screens will still be shown in the Studio tree.

[brooklynlash]

No API error and no console issues, all screens are still showed in the Studio tree but only the name property.

[pixelzoom]

... all screens are still showed in the Studio tree but only the name property.

@brooklynlash You're probably only seeing nameProperty for screens in Studio because you have the "Featured" radio button selected for "PhET-iO Elements". You'll need to select the "All" radio button. Please verify that that is the case.

[brooklynlash]

Yes, my mistake. I need to remember to do that next time

[pixelzoom]

Great, thanks. Closing.