-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update credits for 1.5.0 release #155
Comments
The convention for design credits has been to include the legacy lead/team. @pixelzoom please...
While ph-scale-basics does not have a Java version, it is essentially the first screen of ph-scale, so I think it's appropriate to credit the legacy team there as well. I suspect the credits are already shared between the two sims (as was done in the Gas Props suite), but I wanted to be clear that I understand these changes will affect both sims. |
@arouinfar Yes, the same credits are shared by ph-scale and ph-scale-basics. |
@arouinfar FYI, here are the revised credits: |
So far Logan Bray and Jacob Romero should be added to QA |
Updated QA credits are shown below. @KatieWoe I'll leave this assigned to you until the QA process is finished, in case we need to add additional names. |
@KatieWoe now that 1.4.0-rc.1 testing is completed, please indicate who you would like to add to the QA credits. |
Sorry about that. Everyone looks accounted for in #155 (comment) |
1.4 release branches have been abandoned, and the RC process will be restarted with a new release branch. See #166 (comment). Changing the title of this issue for 1.5 release. |
Found during phetsims/qa#669 My name is in the Team section instead of the QA section, and I think Brooklyn Lash and Clifford Hardin need to be added to QA as well @KatieWoe |
Good catch |
Looks like I need to add @Nancy-Salpepi "Nancy Salpepi" to the QA credits in master and 1.5 branches (ph-scale and ph-scale-basics). Self assigning. |
@pixelzoom @KatieWoe Devon Quispe has also worked on pH. I don't know if anyone else is missing |
This looks ok in rc.2 |
Current credits are shown below. @arouinfar @KatieWoe please let me know what you'd like to change.
The text was updated successfully, but these errors were encountered: