You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this meter doesn't have a separate movable probe, so both probe and positionProperty are irrelevant
it's created in the model, but not actually used in the view
Like the My Solutions screen, there's no need for microScreen.model.pHMeter -- it has no moving parts, and its pH is always the same as the solutions. So it should be removed.
The text was updated successfully, but these errors were encountered:
Something I noticed while working on another issue...
Instrumentation of the pH meter mode in Macro screen looks like this:
There are a few problems here:
valueProperty
is never updated, alwaysnull
probe
andpositionProperty
are irrelevantLike the My Solutions screen, there's no need for
microScreen.model.pHMeter
-- it has no moving parts, and its pH is always the same as the solutions. So it should be removed.The text was updated successfully, but these errors were encountered: