Skip to content

Commit

Permalink
Add phetioVisiblePropertyInstrumented: true, see phetsims/scenery#1447
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Sep 16, 2022
1 parent 4f3bf0a commit d01c77c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
3 changes: 2 additions & 1 deletion js/common/view/WaterFaucetNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ export default class WaterFaucetNode extends Node {
maxWidth: 85,
left: faucetNode.left + 115,
bottom: faucetNode.centerY - 40,
tandem: options.tandem.createTandem( 'waterText' )
tandem: options.tandem.createTandem( 'waterText' ),
phetioVisiblePropertyInstrumented: true
} );

options.children = [ faucetNode, waterText ];
Expand Down
6 changes: 4 additions & 2 deletions js/common/view/graph/GraphScaleSwitch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ export default class GraphScaleSwitch extends ABSwitch<GraphScale> {

// Logarithmic label
const logarithmicText = new Text( PhScaleStrings.logarithmicStringProperty, combineOptions<TextOptions>( {
tandem: options.tandem.createTandem( 'logarithmicText' )
tandem: options.tandem.createTandem( 'logarithmicText' ),
phetioVisiblePropertyInstrumented: true
}, textOptions ) );

// Linear label
const linearText = new Text( PhScaleStrings.linearStringProperty, combineOptions<TextOptions>( {
tandem: options.tandem.createTandem( 'linearText' )
tandem: options.tandem.createTandem( 'linearText' ),
phetioVisiblePropertyInstrumented: true
}, textOptions ) );

super( graphScaleProperty, GraphScale.LOGARITHMIC, logarithmicText, GraphScale.LINEAR, linearText, options );
Expand Down
6 changes: 4 additions & 2 deletions js/common/view/graph/GraphUnitsSwitch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export default class GraphUnitsSwitch extends ABSwitch<GraphUnits> {
align: 'center',
font: PHScaleConstants.AB_SWITCH_FONT,
maxWidth: 125,
tandem: options.tandem.createTandem( 'concentrationText' )
tandem: options.tandem.createTandem( 'concentrationText' ),
phetioVisiblePropertyInstrumented: true
} );

// Quantity (mol)
Expand All @@ -53,7 +54,8 @@ export default class GraphUnitsSwitch extends ABSwitch<GraphUnits> {
align: 'center',
font: PHScaleConstants.AB_SWITCH_FONT,
maxWidth: 90,
tandem: options.tandem.createTandem( 'quantityText' )
tandem: options.tandem.createTandem( 'quantityText' ),
phetioVisiblePropertyInstrumented: true
} );

super( graphUnitsProperty, GraphUnits.MOLES_PER_LITER, concentrationText, GraphUnits.MOLES, quantityText, options );
Expand Down

0 comments on commit d01c77c

Please sign in to comment.