encapsulate prevent:true workaround, #226

phetsims · Sep 28, 2021 · adfc4f2 · adfc4f2
1 parent 314edb3
commit adfc4f2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/js/common/PHScaleConstants.js b/js/common/PHScaleConstants.js
@@ -17,7 +17,13 @@ import phScale from '../phScale.js';
 const PHScaleConstants = {
 
   // ScreenView
-  SCREEN_VIEW_OPTIONS: { layoutBounds: new Bounds2( 0, 0, 1100, 700 ) },
+  SCREEN_VIEW_OPTIONS: {
+    layoutBounds: new Bounds2( 0, 0, 1100, 700 ),
+
+    // Workaround for things shifting around while dragging
+    // See https://github.com/phetsims/scenery/issues/1289 and https://github.com/phetsims/ph-scale/issues/226
+    preventFit: true
+  },
 
   // Credits, shared by ph-scale and ph-scale-basics
   CREDITS: {

diff --git a/js/micro/view/MicroScreenView.js b/js/micro/view/MicroScreenView.js
@@ -138,12 +138,6 @@ class MicroScreenView extends ScreenView {
     } );
 
     const resetAllButton = new ResetAllButton( {
-
-      // preventFit was added as a workaround for https://github.com/phetsims/ph-scale/issues/226.
-      // Setting preventFit on any Node resolves a problem where some UI elements shift up and down
-      // while interacting with the sim. If layer splits are needed in the future and preventFit:true
-      // is added elsewhere, this workaround should be revisited, and you might be able to delete it.
-      preventFit: true,
       scale: 1.32,
       listener: () => {
         this.interruptSubtreeInput();

diff --git a/js/mysolution/view/MySolutionScreenView.js b/js/mysolution/view/MySolutionScreenView.js
@@ -98,12 +98,6 @@ class MySolutionScreenView extends ScreenView {
       } );
 
     const resetAllButton = new ResetAllButton( {
-
-      // preventFit was added as a workaround for https://github.com/phetsims/ph-scale/issues/226.
-      // Setting preventFit on any Node resolves a problem where some UI elements shift up and down
-      // while interacting with the sim. If layer splits are needed in the future and preventFit:true
-      // is added elsewhere, this workaround should be revisited, and you might be able to delete it.
-      preventFit: true,
       scale: 1.32,
       listener: () => {
         this.interruptSubtreeInput();