change constructor signature for ComboBox and its subclasses, phetsim…

…s/sun#769
phetsims · Jun 24, 2022 · a0911a8 · a0911a8
1 parent 6b04f93
commit a0911a8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/js/common/view/SoluteComboBox.js b/js/common/view/SoluteComboBox.js
@@ -19,13 +19,13 @@ import phScale from '../../phScale.js';
 class SoluteComboBox extends ComboBox {
 
   /**
-   * @param {Solute[]} solutes
    * @param {Property.<Solute>} selectedSolute
+   * @param {Solute[]} solutes
    * @param {Node} soluteListParent
    * @param {Object} [options]
    * @constructor
    */
-  constructor( solutes, selectedSolute, soluteListParent, options ) {
+  constructor( selectedSolute, solutes, soluteListParent, options ) {
 
     options = merge( {
       listPosition: 'below',
@@ -81,7 +81,7 @@ class SoluteComboBox extends ComboBox {
       textNode.maxWidth = maxWidth;
     } );
 
-    super( items, selectedSolute, soluteListParent, options );
+    super( selectedSolute, items, soluteListParent, options );
   }
 }
 

diff --git a/js/macro/view/MacroScreenView.js b/js/macro/view/MacroScreenView.js
@@ -104,7 +104,7 @@ class MacroScreenView extends ScreenView {
 
     // solutes combo box
     const soluteListParent = new Node();
-    const soluteComboBox = new SoluteComboBox( model.solutes, model.dropper.soluteProperty, soluteListParent, {
+    const soluteComboBox = new SoluteComboBox( model.dropper.soluteProperty, model.solutes, soluteListParent, {
       maxWidth: 400,
       tandem: tandem.createTandem( 'soluteComboBox' )
     } );

diff --git a/js/micro/view/MicroScreenView.js b/js/micro/view/MicroScreenView.js
@@ -132,7 +132,7 @@ class MicroScreenView extends ScreenView {
 
     // solutes combo box
     const soluteListParent = new Node();
-    const soluteComboBox = new SoluteComboBox( model.solutes, model.dropper.soluteProperty, soluteListParent, {
+    const soluteComboBox = new SoluteComboBox( model.dropper.soluteProperty, model.solutes, soluteListParent, {
       maxWidth: 400,
       tandem: tandem.createTandem( 'soluteComboBox' )
     } );