-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce js file extension in imports #407
Comments
I experimented with that, but it is a pretty naiive test, as it doesn't support a case like I updated it and moved it to the base |
There's a few website imports getting caught by this, but it's unclear to me why all imports that don't have a suffix are not breaking, see https://github.com/phetsims/website-meteor/issues/813. Any ideas? |
Well that isn't ideal! I think the best thing for now is to turn off this error until we can implement the plugin directly as an actual solution. |
From phetsims/chipper#1498. There is a plugin that we can add a lint rule for:
Two options:
https://github.com/import-js/eslint-plugin-import/blob/67cc79841fc823ad4af2532af2dc6704e4b3b03a/docs/rules/extensions.md
https://github.com/solana-labs/eslint-plugin-require-extensions
@samreid, what do you think?
The text was updated successfully, but these errors were encountered: