Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteer from v1.11.0 to v2.1.1 (latest) #170

Closed
chrisklus opened this issue Apr 4, 2020 · 4 comments
Closed

Update puppeteer from v1.11.0 to v2.1.1 (latest) #170

chrisklus opened this issue Apr 4, 2020 · 4 comments
Assignees

Comments

@chrisklus
Copy link
Contributor

This update will fix phetsims/chipper#928.

I'm not sure who to ask before doing this and what all needs to be checked after it's updated. If updating to the latest version is problematic, a small update to v1.12.0 will likely still fix the above issue.

Assigning to @zepumph and @samreid for now, please feel free to unassign and recommend someone else.

@zepumph
Copy link
Member

zepumph commented Apr 5, 2020 via email

@samreid
Copy link
Member

samreid commented Apr 5, 2020

Why does perennial even have puppeteer? It was added in #138 by @zepumph, so I'll leave assigned to him for discussion.

Yes, chipper's puppeteer updates the phet-io files.

@samreid samreid removed their assignment Apr 5, 2020
@chrisklus
Copy link
Contributor Author

Oh whoops, yeah the problem from phetsims/chipper#928 is fixed if i revert my local update in perennial and npm prune && npm install in chipper. Thanks.

@zepumph
Copy link
Member

zepumph commented Jun 8, 2020

Why does perennial even have puppeteer?

I added it for the PDOMComparison task.

I think this issue is now a duplicate of phetsims/chipper#949. Closing

@zepumph zepumph closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants