-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update puppeteer from v1.11.0 to v2.1.1 (latest) #170
Comments
I don't think perennials puppeteer is used for update phet io files.
Wouldn't it be chippers? I updated chippers to fix an npm vulnerability
last month.
…On Sat, Apr 4, 2020, 14:53 Chris Klusendorf ***@***.***> wrote:
Assigned #170 <#170> to
@zepumph <https://github.com/zepumph>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#170 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUKB33QCYYTNG6XZCBD6LLRK627XANCNFSM4L7LNWLQ>
.
|
Oh whoops, yeah the problem from phetsims/chipper#928 is fixed if i revert my local update in perennial and |
I added it for the PDOMComparison task. I think this issue is now a duplicate of phetsims/chipper#949. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This update will fix phetsims/chipper#928.
I'm not sure who to ask before doing this and what all needs to be checked after it's updated. If updating to the latest version is problematic, a small update to
v1.12.0
will likely still fix the above issue.Assigning to @zepumph and @samreid for now, please feel free to unassign and recommend someone else.
The text was updated successfully, but these errors were encountered: