Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate missing libraries #118

Closed
mattpen opened this issue Dec 10, 2018 · 3 comments
Closed

Investigate missing libraries #118

mattpen opened this issue Dec 10, 2018 · 3 comments
Assignees

Comments

@mattpen
Copy link
Contributor

mattpen commented Dec 10, 2018

The third party libraries are missing from https://phet.colorado.edu/en/simulation/graphing-quadratics and graphing-quadratics is missing from https://github.com/phetsims/sherpa/blob/master/third-party-licenses.md#graphing-quadratics.

Assigning to myself to investigate and correct.

@mattpen mattpen self-assigned this Dec 10, 2018
@mattpen
Copy link
Contributor Author

mattpen commented Dec 11, 2018

@pixelzoom - It looks like reportThirdParty.js should have run in the grunt task on your machine when you deployed graphing-quadratics to production last Friday. Do you remember if it ran this task and if so was there any error?

@pixelzoom
Copy link
Contributor

I was admittedly multitasking. But I don't recall seeing any message about reportThirdParty.js or errors when running grunt production --brands=phet --branch=1.0. And I received an email indicating that the build had succeeded.

Why is reportThirdParty.js generated locally? Why isn't it handled by the build server?

@pixelzoom pixelzoom removed their assignment Dec 11, 2018
mattpen added a commit to phetsims/sherpa that referenced this issue Dec 11, 2018
@mattpen
Copy link
Contributor Author

mattpen commented Dec 18, 2018

I ran reportThirdParty.js manually and GQ has been added to the appropriate places.

Why isn't it handled by the build server?

In #106 we decided to add it as a scheduled service on bayes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants