Skip to content

Commit

Permalink
unit tests should be run in brand=phet-io, #191
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Aug 20, 2020
1 parent 5379f86 commit bbe460d
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions js/listContinuousTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
const getActiveRepos = require( './common/getActiveRepos' );
const getRepoList = require( './common/getRepoList' );
const fs = require( 'fs' );
const assert = require( 'assert' );

const repos = getActiveRepos();
const phetioRepos = getRepoList( 'testable-phet-io' );
Expand All @@ -21,10 +20,6 @@ const interactiveDescriptionRepos = getRepoList( 'interactive-descriptions' );
const phetioNoState = getRepoList( 'phet-io-state-unsupported' );
const unitTestRepos = getRepoList( 'unit-tests' );

// A list of repos not in the testable-phet-io list, but that should still be unit tested in
const unitTestInPhetioBrand = [ 'axon', 'tandem' ];
unitTestInPhetioBrand.forEach( repo => assert( unitTestRepos.includes( repo ), `${repo} should be in "unit-tests" list if in this one.` ) );

/**
* {Array.<string>} test
* {string} type
Expand Down Expand Up @@ -215,14 +210,9 @@ unitTestRepos.forEach( repo => {
return;
}

// All tests should work with no query parameters, with assertions enabled
const queryParameters = [ '', '?ea' ];

// PhET-iO repos also test with brand=phet-io
if ( phetioRepos.includes( repo ) || unitTestInPhetioBrand.includes( repo ) ) {
queryParameters.push( '?brand=phet-io' );
queryParameters.push( '?ea&brand=phet-io' );
}
// All tests should work with no query parameters, with assertions enabled, and should support PhET-iO also, so test
// with brand=phet-io
const queryParameters = [ '', '?ea', '?brand=phet-io', '?ea&brand=phet-io' ];
queryParameters.forEach( queryString => {

// Don't test phet-io or tandem unit tests in phet brand, they are meant for phet-io brand
Expand Down

0 comments on commit bbe460d

Please sign in to comment.