add support for sim specific bad text, phetsims/chipper#728

eslint/rules/bad-sim-text.js

@@ -0,0 +1,51 @@
+// Copyright 2019, University of Colorado Boulder
+/* eslint-disable */
+
+/**
+ * NOTE: this file is a duplicate of bad-text.js, but it is only run on sim specific code, if you are looking for
+ * adding general bad text, see `./bad-text.js`
+ *
+ * Lint detector for invalid text.  Checks the entire file and does not correctly report line number.
+ * Lint is disabled for this file so the bad texts aren't themselves flagged.
+ *
+ * @author Sam Reid (PhET Interactive Simulations)
+ * @author Michael Kauzmann (PhET Interactive Simulations)
+ */
+module.exports = function( context ) {
+  'use strict';
+
+  var badTextsForSimCode = [
+
+    'Math.round',
+    'Math.random',
+    '_.shuffle',
+    '_.sample',
+    '_.random',
+    'new Random()',
+
+    // IE doesn't support:
+    'Number.parseInt()',
+    'Array.prototype.find'
+
+  ];
+
+  // NOTE: this code is duplicated in `bad-text.js`, don't edit this without updating there too
+  return {
+    Program: function( node ) {
+      var sourceCode = context.getSourceCode();
+      var text = sourceCode.text;
+      badTextsForSimCode.forEach( function( badText ) {
+        if ( text.indexOf( badText ) >= 0 ) {
+          context.report( {
+            node: node,
+            message: 'File contains bad text: \'' + badText + '\''
+          } );
+        }
+      } )
+    }
+  };
+};
+
+module.exports.schema = [
+  // JSON Schema for rule options goes here
+];

eslint/rules/bad-text.js

@@ -1,10 +1,13 @@
-// Copyright 2018, University of Colorado Boulder
+// Copyright 2018-2019, University of Colorado Boulder
 /* eslint-disable */
 
 /**
  * Lint detector for invalid text.  Checks the entire file and does not correctly report line number.
  * Lint is disabled for this file so the bad texts aren't themselves flagged.
  *
+ * NOTE: this lint rule is applied to all lintable files in the project. If you are looking to add rules that only apply
+ * to sim specific code, see `./bad-sim-text.js`
+ *
  * @author Sam Reid (PhET Interactive Simulations)
  */
 module.exports = function( context ) {
@@ -32,6 +35,7 @@ module.exports = function( context ) {
     '@return '
   ];
 
+  // NOTE: this code is duplicated in `bad-text.js`, don't edit this without updating there too
   return {
     Program: function( node ) {
       var sourceCode = context.getSourceCode();

eslint/sim_es6_eslintrc.js

@@ -8,7 +8,7 @@
  * Eslint config applied only to sims that are completely written in es6, with no es5 code.
  */
 module.exports = {
-  extends: './.eslintrc.js',
+  extends: './sim_eslintrc.js',
   rules: {
     'no-var': 2
   }

eslint/sim_eslintrc.js

@@ -0,0 +1,15 @@
+// Copyright 2018, University of Colorado Boulder
+// @author Michael Kauzmann
+
+/* eslint-env node */
+'use strict';
+
+/**
+ * Eslint config applied only to sims that are completely written in es6, with no es5 code.
+ */
+module.exports = {
+  extends: './.eslintrc.js',
+  rules: {
+    'bad-sim-text': 2
+  }
+};