apply fixes for allow-parens as needed lint rule, phetsims/chipper#790

phetsims · Sep 19, 2019 · 82f6e31 · 82f6e31
1 parent 86a61f3
commit 82f6e31
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 16 deletions.
diff --git a/js/build-server/addTranslator.js b/js/build-server/addTranslator.js
@@ -14,7 +14,7 @@ const winston = require( 'winston' );
  * @param translatorId
  */
 module.exports = async function addTranslator( locale, simName, translatorId ) {
-  return new Promise( ( resolve ) => {
+  return new Promise( resolve => {
     // create the URL
     const addTranslatorURL = constants.BUILD_SERVER_CONFIG.productionServerURL + '/services/add-html-translator?simName=' + simName +
                              '&locale=' + locale + '&userId=' + translatorId + '&authorizationCode=' +

diff --git a/js/build-server/notifyServer.js b/js/build-server/notifyServer.js
@@ -23,7 +23,7 @@ const winston = require( 'winston' );
  */
 module.exports = async function notifyServer( options ) {
   if ( options.brand === constants.PHET_BRAND ) {
-    return new Promise( ( resolve ) => {
+    return new Promise( resolve => {
       const project = 'html/' + options.simName;
       let url = constants.BUILD_SERVER_CONFIG.productionServerURL + '/services/synchronize-project?projectName=' + project;
       if ( options.locales && options.locales !== '*' && options.locales !== 'en' && options.locales.indexOf( ',' ) < 0 ) {

diff --git a/js/build-server/taskWorker.js b/js/build-server/taskWorker.js
@@ -371,7 +371,7 @@ module.exports = ( task, taskCallback ) => {
     .then( () => {
         taskCallback();
       }
-    ).catch( ( reason ) => {
+    ).catch( reason => {
     taskCallback( reason );
   } );
 };
diff --git a/js/common/Maintenance.js b/js/common/Maintenance.js
@@ -413,7 +413,7 @@ module.exports = ( function() {
       const maintenance = Maintenance.load();
       const patch = maintenance.findPatch( patchName );
 
-      await Maintenance.addNeededPatches( patchName, async ( releaseBranch ) => {
+      await Maintenance.addNeededPatches( patchName, async releaseBranch => {
         return await releaseBranch.isMissingSHA( patch.repo, sha );
       } );
     }
@@ -429,7 +429,7 @@ module.exports = ( function() {
       const maintenance = Maintenance.load();
       const patch = maintenance.findPatch( patchName );
 
-      await Maintenance.addNeededPatches( patchName, async ( releaseBranch ) => {
+      await Maintenance.addNeededPatches( patchName, async releaseBranch => {
         return await releaseBranch.includesSHA( patch.repo, sha );
       } );
     }
@@ -443,7 +443,7 @@ module.exports = ( function() {
      * @param {function(ReleaseBranch, builtFile:string): Promise.<boolean>} filter
      */
     static async addNeededPatchesBuildFilter( patchName, filter ) {
-      await Maintenance.addNeededPatches( patchName, async ( releaseBranch ) => {
+      await Maintenance.addNeededPatches( patchName, async releaseBranch => {
         await checkoutTarget( releaseBranch.repo, releaseBranch.branch, true );
         await gitPull( releaseBranch.repo );
         await build( releaseBranch.repo );
@@ -530,7 +530,7 @@ module.exports = ( function() {
       const maintenance = Maintenance.load();
       const patch = maintenance.findPatch( patchName );
 
-      await Maintenance.removeNeededPatches( patchName, async ( releaseBranch ) => {
+      await Maintenance.removeNeededPatches( patchName, async releaseBranch => {
         return await releaseBranch.isMissingSHA( patch.repo, sha );
       } );
     }
@@ -546,7 +546,7 @@ module.exports = ( function() {
       const maintenance = Maintenance.load();
       const patch = maintenance.findPatch( patchName );
 
-      await Maintenance.removeNeededPatches( patchName, async ( releaseBranch ) => {
+      await Maintenance.removeNeededPatches( patchName, async releaseBranch => {
         return await releaseBranch.includesSHA( patch.repo, sha );
       } );
     }

diff --git a/js/grunt/printPhetioLinks.js b/js/grunt/printPhetioLinks.js
@@ -74,7 +74,7 @@ async function usesTopLevelIndex( repo, branch ) {
 const getVersion = simData => `${simData.versionMajor}.${simData.versionMinor}`;
 
 // {Object} metadata -> branch name
-const getBranch = ( simData ) => {
+const getBranch = simData => {
   let branch = `${simData.versionMajor}.${simData.versionMinor}`;
   if ( simData.versionSuffix.length ) {
     branch += '-' + simData.versionSuffix; // additional dash required

diff --git a/test/perennialGruntTest.js b/test/perennialGruntTest.js
@@ -34,20 +34,20 @@ async function getLikelyNextBranch( repo, incrementMajor, incrementMinor ) {
   return `${currentMajor}.${currentMinor}`;
 }
 
-qunit.test( 'Checkout target', async ( assert ) => {
+qunit.test( 'Checkout target', async assert => {
   assert.timeout( 120000 );
   await execute( gruntCommand, [ 'checkout-target', '--repo=chains', '--target=1.9' ], '.' );
   await execute( gruntCommand, [ 'checkout-master', '--repo=chains' ], '.' );
   assert.expect( 0 );
 } );
 
-qunit.test( 'NPM update', async ( assert ) => {
+qunit.test( 'NPM update', async assert => {
   assert.timeout( 120000 );
   await execute( gruntCommand, [ 'npm-update', '--repo=chains' ], '.' );
   assert.expect( 0 );
 } );
 
-qunit.test( 'Bumper one-off (random)', async ( assert ) => {
+qunit.test( 'Bumper one-off (random)', async assert => {
   assert.timeout( 3000000 );
   const branch = 'oneoff' + Math.random().toString( 36 ).substring( 2 );
 
@@ -60,25 +60,25 @@ qunit.test( 'Bumper one-off (random)', async ( assert ) => {
   assert.expect( 0 );
 } );
 
-qunit.test( 'Bumper dev phet,phet-io', async ( assert ) => {
+qunit.test( 'Bumper dev phet,phet-io', async assert => {
   assert.timeout( 600000 );
   await execute( gruntCommand, [ 'dev', '--repo=bumper', '--brands=phet,phet-io', '--noninteractive' ], '.' );
   assert.expect( 0 );
 } );
 
-qunit.test( 'Bumper dev phet', async ( assert ) => {
+qunit.test( 'Bumper dev phet', async assert => {
   assert.timeout( 600000 );
   await execute( gruntCommand, [ 'dev', '--repo=bumper', '--brands=phet', '--noninteractive' ], '.' );
   assert.expect( 0 );
 } );
 
-qunit.test( 'Bumper dev phet-io', async ( assert ) => {
+qunit.test( 'Bumper dev phet-io', async assert => {
   assert.timeout( 600000 );
   await execute( gruntCommand, [ 'dev', '--repo=bumper', '--brands=phet-io', '--noninteractive' ], '.' );
   assert.expect( 0 );
 } );
 
-qunit.test( 'Major bump, RC/Production', async( assert ) => {
+qunit.test( 'Major bump, RC/Production', async assert => {
   assert.timeout( 3000000 );
   const branch = await getLikelyNextBranch( 'bumper', true, false );