-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Stopwatch and StopwatchNode #216
Comments
@jonathanolson can you please review at your convenience? |
Looks good, thanks! |
There are still TODOs marked for this issue, discovered during phetsims/chipper#946 |
It looks like Pendulum lab has its own stopwatch. That should be deleted and the scenery-phet common code one should be used instead. Unassigning until we return focus to this sim. |
@samreid This issue is ready-for-review but unassigned. Should ready-for-review be removed? |
I think this issue should remain open but not ready for review. It's unclear how we will want to treat PeriodTimer (which currently extends PENDULUM_LAB/Stopwatch) and PeriodTimerNode, but we will likely want to make sure things are working nicely during phet-io instrumentation. |
We were looking at examples of StopwatchNode during today's Projectile Motion design meeting, and discovered the published version of Pendulum Lab was using a slightly different version of the component. @matthew-blackman requested that I open an assign an issue to him to investigate, but looks like there's already an issue for it. |
From phetsims/gas-properties#170: PENDULUM_LAB/StopwatchNode now has features supported in SCENERY_PHET, and should be updated accordingly.
I've made these changes and will reassign to responsible dev for review after pushing.
The text was updated successfully, but these errors were encountered: