Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Stopwatch and StopwatchNode #216

Open
samreid opened this issue Dec 17, 2019 · 7 comments
Open

Use Stopwatch and StopwatchNode #216

samreid opened this issue Dec 17, 2019 · 7 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Dec 17, 2019

From phetsims/gas-properties#170: PENDULUM_LAB/StopwatchNode now has features supported in SCENERY_PHET, and should be updated accordingly.

I've made these changes and will reassign to responsible dev for review after pushing.

@samreid samreid self-assigned this Dec 17, 2019
samreid added a commit that referenced this issue Dec 17, 2019
@samreid
Copy link
Member Author

samreid commented Jan 24, 2020

@jonathanolson can you please review at your convenience?

@jonathanolson
Copy link
Contributor

Looks good, thanks!

@samreid
Copy link
Member Author

samreid commented May 21, 2020

There are still TODOs marked for this issue, discovered during phetsims/chipper#946

@samreid samreid reopened this May 21, 2020
@samreid
Copy link
Member Author

samreid commented May 26, 2020

It looks like Pendulum lab has its own stopwatch. That should be deleted and the scenery-phet common code one should be used instead. Unassigning until we return focus to this sim.

@pixelzoom
Copy link
Contributor

@samreid This issue is ready-for-review but unassigned. Should ready-for-review be removed?

@samreid
Copy link
Member Author

samreid commented Feb 19, 2021

I think this issue should remain open but not ready for review. It's unclear how we will want to treat PeriodTimer (which currently extends PENDULUM_LAB/Stopwatch) and PeriodTimerNode, but we will likely want to make sure things are working nicely during phet-io instrumentation.

@samreid samreid removed their assignment Feb 19, 2021
@arouinfar
Copy link
Contributor

We were looking at examples of StopwatchNode during today's Projectile Motion design meeting, and discovered the published version of Pendulum Lab was using a slightly different version of the component. @matthew-blackman requested that I open an assign an issue to him to investigate, but looks like there's already an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants