Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QA credits #70

Closed
zepumph opened this issue Aug 4, 2017 · 3 comments
Closed

Add QA credits #70

zepumph opened this issue Aug 4, 2017 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Aug 4, 2017

similar to phetsims/resistance-in-a-wire#89, there are no qa credits for the current sim in master. We should add them.

zepumph added a commit that referenced this issue Aug 4, 2017
@zepumph
Copy link
Member Author

zepumph commented Aug 4, 2017

@phet-steele let me know if the above commit looks good.

@zepumph zepumph removed their assignment Aug 4, 2017
@phet-steele
Copy link

@zepumph it's good, but we need more now. Alex Dornan, Ethan Johnsonas well, please. You'll probably have to put a line break in there somewhere. Isn't this technically #54?

@phet-steele phet-steele assigned zepumph and unassigned phet-steele Aug 4, 2017
@zepumph
Copy link
Member Author

zepumph commented Aug 4, 2017

Oh you're right thanks!

BTW here is what credits look like, they use MultilineText so you don't have to add new lines:

   if ( credits.qualityAssurance ) {
      children.push( new MultiLineText( StringUtils.format( creditsQualityAssuranceString, '\u202a' + credits.qualityAssurance + '\u202c' ), multiLineTextOptions ) );
    }

to be carried on in #54

@zepumph zepumph closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants