Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out string for i18n #26

Closed
zepumph opened this issue Jan 13, 2023 · 3 comments
Closed

Factor out string for i18n #26

zepumph opened this issue Jan 13, 2023 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jan 13, 2023

No description provided.

zepumph added a commit that referenced this issue Jan 14, 2023
@pixelzoom
Copy link
Contributor

@zepumph No one is assigned and there's no information here abpout what string should be factored out. Please provide a description.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 15, 2023

This issue was apparently created to associate with this TODO in NumberSuiteCommonPreferencesNode.ts:

    // TODO: factor out this string if we like this, https://github.com/phetsims/number-suite-common/issues/26
    const loadAllHtmlText = new RichText(
      'To display a second language, run the <a href="{{url}}">“all” version</a> of Number Play.', {

Please don't create GitHub issues with no description. It wastes people's time.

@pixelzoom pixelzoom assigned pixelzoom and unassigned zepumph Jan 15, 2023
@pixelzoom
Copy link
Contributor

Move to #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants