Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the OnesPlayAreaNode #82

Closed
Luisav1 opened this issue Dec 13, 2021 · 3 comments
Closed

Refactor the OnesPlayAreaNode #82

Luisav1 opened this issue Dec 13, 2021 · 3 comments
Assignees

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Dec 13, 2021

From #75

Are there any TODO or FIXME or REVIEW comments in the code? They should be addressed or promoted to GitHub issues.

The parts of CountingGameLevelNode.js, and other screens that are used for the play area need to be refactored once the play area is updated. Once the bounds handling for the OnesPlayArea and the paper numbers are improved, we don't need to add a y margin to them anymore.

@chrisklus
Copy link
Contributor

This work was completed in #118, closing.

@zepumph
Copy link
Member

zepumph commented Apr 5, 2023

One more TODO pointing to this issue:

//TODO https://github.com/phetsims/number-play/issues/82 The parts of this file that are used for the countingArea node need to be refactored once the countingArea is updated.
const countingAreaNode = new Rectangle( {
rectWidth: RECTANGLE_WIDTH,
rectHeight: RECTANGLE_HEIGHT
} );

@chrisklus
Copy link
Contributor

Last TODO improved above, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants