Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert PlayObjectType to a supported enumeration pattern #80

Closed
Luisav1 opened this issue Dec 13, 2021 · 2 comments
Closed

Convert PlayObjectType to a supported enumeration pattern #80

Luisav1 opened this issue Dec 13, 2021 · 2 comments
Assignees
@chrisklus
Labels
dev:code-review status:ready-for-review

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Dec 13, 2021

From #75

Are there any TODO or FIXME or REVIEW comments in the code? They should be addressed or promoted to GitHub issues.
chrisklus referenced this issue in phetsims/counting-common Jan 12, 2022
@chrisklus
Convert CountingCommonConstants.ts and CountingCommonUtils.ts, update…
859506e 
… usages, see #3
chrisklus added a commit that referenced this issue Jan 12, 2022
@chrisklus
Make SubitizeObjectType extend from PlayObjectType, see #80
08e60cb
@pixelzoom pixelzoom changed the title Convert PlayObjectType to a supperted enumeration pattern Convert PlayObjectType to a supported enumeration pattern Jan 4, 2023
@pixelzoom
Copy link
Contributor

I inspected PlayObjectType and it is an Enumeration. It looks great, a nice example of using the instanceType option in an EnumerationValue class hierarchy.

@chrisklus I think this can be closed.

@chrisklus
Copy link
Contributor

Agreed, thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @chrisklus @Luisav1