Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When language toggle triggers speech is inconsistent across screens #157

Closed
Nancy-Salpepi opened this issue Apr 15, 2022 · 5 comments
Closed
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3.1

Browser
Chrome

Problem description
For phetsims/qa#797, when using both the ReadAloud and secondLocale= es query parameters, I noticed an inconsistency between screens. On the Compare Screen, when I toggle between the 2 locales, the statement is read aloud in the new language. If I do the same of the Ten or Twenty Screen, that does not happen.

Steps to reproduce

  1. add both query parameters to url: readAloud and secondLocale=es
  2. On the Compare screen, toggle to Español
  3. Toggle back to English
  4. Go to the Ten or Twenty screen, toggle to Español
  5. Toggle back to English

Visuals

readAloud.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Play‬ URL: https://phet-dev.colorado.edu/html/number-play/1.0.0-rc.1/phet/number-play_all_phet.html?secondLocale=es&readAloud Version: 1.0.0-rc.1 2022-04-14 15:43:27 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.88 Safari/537.36 Language: en-US Window: 1431x690 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Apr 15, 2022
@chrisklus
Copy link
Contributor

Thanks @Nancy-Salpepi! Discussed with @amanda-phet and we think the Ten and Twenty screen behavior is correct. I'll change the Compare screen.

@chrisklus
Copy link
Contributor

Completed above and ready for cherry-picking.

@chrisklus
Copy link
Contributor

Awesome, thanks @KatieWoe and @Nancy-Salpepi! Closing.

@chrisklus
Copy link
Contributor

Also cherry-picked for #166.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants