-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Leak #127
Comments
Oops, I forgot to update this issue on Friday. @jonathanolson helped me look into the memory status of this sim and we found that it had been greatly improved since the last tests. Initial size was around 50 MB and after 5-7 min of testing we never saw it go above 56 MB. There was one dragListener to dispose that I am about to commit. I will do a new memory test on 1.0 prototype to confirm no maintenance release is needed for this issue |
@zepumph and I addressed the leaky code in the Lab Screen. Another full sim memory test indicates there are no other leaks. Assign to @chrisklus for review. |
@marlitas and I co-reviewed and everything looks great, thanks! Closing. |
For phetsims/qa#771. This seems to indicate a memory leak.
Start: 25.4 MB
1 min: 127
2 min: 200
3 min: 250
4 min: 297
5 min: 343
The text was updated successfully, but these errors were encountered: