Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParticlesWebGLNode vertex buffer should be persistent #47

Closed
jonathanolson opened this issue Dec 9, 2014 · 2 comments
Closed

ParticlesWebGLNode vertex buffer should be persistent #47

jonathanolson opened this issue Dec 9, 2014 · 2 comments
Assignees
@jonathanolson
Labels
dev:code-review

Comments

@jonathanolson
Copy link
Contributor

Right now it's getting created and destroyed every frame in render().

Ideally it should be created in initialize(), and never destroyed. (gl.deleteBuffer is unneeded).

See code review #29
AshrafSharf pushed a commit that referenced this issue Dec 17, 2014
@ashrafabu
vertex buffer is created only on initailze and delete buffer statment…
67a2a96 
… is removed from render function issue #47
@AshrafSharf
Copy link

Fixed - Vertex buffer is created only on Initialize method and delete buffer is removed from render call.

@jonathanolson
Copy link
Contributor Author

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @AshrafSharf