Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuron patches for scenery #120

Closed
phet-steele opened this issue Feb 19, 2016 · 3 comments
Closed

Neuron patches for scenery #120

phet-steele opened this issue Feb 19, 2016 · 3 comments
Assignees

Comments

@phet-steele
Copy link
Contributor

@jbphet neuron needs to be patched from two scenery issues:

Canvas renderer not properly set on Edge for navbar/menu/homescreen phetsims/scenery/issues/515
(This is the main fix for phetsims/joist/issues/321)

Text boundsMethod 'fast' should still allow Canvas rendering (but prevent fitting) phetsims/scenery/issues/516 which fixes the concentration layout:
neuron

@jbphet
Copy link
Contributor

jbphet commented Feb 22, 2016

@jonathanolson and I discussed this and decided that instead of trying to patch Scenery so that bounds method values of 'fast' still allowed canvas, I would just try turning off that bounds method and using the default and qualify the performance on iPad to see if it reduced significantly. I ran three trials with and without this flag set, measured the results using the neuronProfiler=1 flag, and found no performance degradation. I'll remove the flag and move forward with the next RC.

jbphet added a commit that referenced this issue Feb 22, 2016
…issues that it was causing when rendering on the Edge browser, see #120
jbphet added a commit that referenced this issue Feb 22, 2016
…issues that it was causing when rendering on the Edge browser, see #120
@phet-steele
Copy link
Contributor Author

@jbphet reported as successfully fixed.

@jbphet
Copy link
Contributor

jbphet commented Feb 26, 2016

Patches and code changes complete, closing.

@jbphet jbphet closed this as completed Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants