-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neuron patches for scenery #120
Comments
…of MS Edge browser, see #120, phetsims/scenery#515, and phetsims/joist#321
@jonathanolson and I discussed this and decided that instead of trying to patch Scenery so that bounds method values of 'fast' still allowed canvas, I would just try turning off that bounds method and using the default and qualify the performance on iPad to see if it reduced significantly. I ran three trials with and without this flag set, measured the results using the |
…issues that it was causing when rendering on the Edge browser, see #120
…issues that it was causing when rendering on the Edge browser, see #120
@jbphet reported as successfully fixed. |
Patches and code changes complete, closing. |
@jbphet neuron needs to be patched from two scenery issues:
Canvas renderer not properly set on Edge for navbar/menu/homescreen phetsims/scenery/issues/515
(This is the main fix for phetsims/joist/issues/321)
Text boundsMethod 'fast' should still allow Canvas rendering (but prevent fitting) phetsims/scenery/issues/516 which fixes the concentration layout:
The text was updated successfully, but these errors were encountered: