-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Review #1
Comments
samreid
added a commit
that referenced
this issue
Oct 24, 2014
jbphet
added a commit
that referenced
this issue
Oct 24, 2014
… some whitespace and removed some blank lines. Other than that, the code adhered to PhET's code style standards. See #1
This was referenced Oct 24, 2014
samreid
added a commit
that referenced
this issue
Oct 27, 2014
samreid
added a commit
that referenced
this issue
Oct 27, 2014
jbphet
added a commit
that referenced
this issue
Oct 27, 2014
jbphet
added a commit
that referenced
this issue
Oct 27, 2014
jbphet
added a commit
that referenced
this issue
Nov 12, 2014
jbphet
added a commit
that referenced
this issue
Nov 21, 2014
I'm going to close this issue and track the remaining code review comments under #29, and will log any other functional issues as separate tickets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@AshrafSharf has been doing excellent work on porting the simulation, and it is time to have the PhET developers take a closer look. @samreid & @jbphet will take a closer look, and follow roughly the following steps:
The text was updated successfully, but these errors were encountered: