Skip to content

Commit

Permalink
Renaming load-runtime-strings.js => load-unbuilt-strings.js, and rena…
Browse files Browse the repository at this point in the history
…ming string module files, see phetsims/chipper#922
  • Loading branch information
jonathanolson committed Mar 31, 2020
1 parent fb13d8e commit 70032a7
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion js/neuron-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import Sim from '../../joist/js/Sim.js';
import SimLauncher from '../../joist/js/SimLauncher.js';
import neuronStrings from './neuron-strings.js';
import neuronStrings from './neuronStrings.js';
import NeuronProfiler from './neuron/common/NeuronProfiler.js';
import NeuronQueryParameters from './neuron/common/NeuronQueryParameters.js';
import NeuronScreen from './neuron/view/NeuronScreen.js';
Expand Down
2 changes: 1 addition & 1 deletion js/neuron/view/ConcentrationReadoutLayerNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import PhetFont from '../../../../scenery-phet/js/PhetFont.js';
import Node from '../../../../scenery/js/nodes/Node.js';
import Rectangle from '../../../../scenery/js/nodes/Rectangle.js';
import Text from '../../../../scenery/js/nodes/Text.js';
import neuronStrings from '../../neuron-strings.js';
import neuronStrings from '../../neuronStrings.js';
import neuron from '../../neuron.js';
import PotassiumIon from '../model/PotassiumIon.js';
import SodiumIon from '../model/SodiumIon.js';
Expand Down
2 changes: 1 addition & 1 deletion js/neuron/view/NeuronScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import Path from '../../../../scenery/js/nodes/Path.js';
import Rectangle from '../../../../scenery/js/nodes/Rectangle.js';
import SceneryUtils from '../../../../scenery/js/util/Utils.js'; // eslint-disable-line require-statement-match
import RectangularPushButton from '../../../../sun/js/buttons/RectangularPushButton.js';
import neuronStrings from '../../neuron-strings.js';
import neuronStrings from '../../neuronStrings.js';
import neuron from '../../neuron.js';
import NeuronConstants from '../common/NeuronConstants.js';
import AxonBodyNode from './AxonBodyNode.js';
Expand Down
2 changes: 1 addition & 1 deletion js/neuron/view/chart/MembranePotentialChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import Path from '../../../../../scenery/js/nodes/Path.js';
import Text from '../../../../../scenery/js/nodes/Text.js';
import TextPushButton from '../../../../../sun/js/buttons/TextPushButton.js';
import Panel from '../../../../../sun/js/Panel.js';
import neuronStrings from '../../../neuron-strings.js';
import neuronStrings from '../../../neuronStrings.js';
import neuron from '../../../neuron.js';
import NeuronConstants from '../../common/NeuronConstants.js';
import ChartCursor from './ChartCursor.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import Text from '../../../../../scenery/js/nodes/Text.js';
import VBox from '../../../../../scenery/js/nodes/VBox.js';
import Checkbox from '../../../../../sun/js/Checkbox.js';
import Panel from '../../../../../sun/js/Panel.js';
import neuronStrings from '../../../neuron-strings.js';
import neuronStrings from '../../../neuronStrings.js';
import neuron from '../../../neuron.js';
import NeuronConstants from '../../common/NeuronConstants.js';

Expand Down
2 changes: 1 addition & 1 deletion js/neuron/view/controlpanel/IonsAndChannelsLegendPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import HStrut from '../../../../../scenery/js/nodes/HStrut.js';
import Text from '../../../../../scenery/js/nodes/Text.js';
import VBox from '../../../../../scenery/js/nodes/VBox.js';
import Panel from '../../../../../sun/js/Panel.js';
import neuronStrings from '../../../neuron-strings.js';
import neuronStrings from '../../../neuronStrings.js';
import neuron from '../../../neuron.js';
import NeuronConstants from '../../common/NeuronConstants.js';
import PotassiumGatedChannel from '../../model/PotassiumGatedChannel.js';
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions neuron_en.html
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,13 @@
};

// Kick off string loading immediately
loadURL( '../chipper/js/load-runtime-strings.js' );
loadURL( '../chipper/js/load-unbuilt-strings.js' );

// Queue all of the preloads to be loaded.
preloads.forEach( preload => loadURL( preload ) );

// Module loading in compilation-free (development) mode will be kicked off once strings are loaded.
// This is done in load-runtime-strings.js
// This is done in load-unbuilt-strings.js
window.phet.chipper.loadModules = () => loadURL( 'js/neuron-main.js', 'module' );
</script>
</body>
Expand Down

0 comments on commit 70032a7

Please sign in to comment.