Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO design review for 1.5 release #323

Closed
pixelzoom opened this issue Aug 29, 2022 · 6 comments
Closed

PhET-iO design review for 1.5 release #323

pixelzoom opened this issue Aug 29, 2022 · 6 comments

Comments

@pixelzoom
Copy link
Contributor

#319 (add support for dynamic locale) is requiring a large number of API changes. And there are many API changes and additions that have been added to common code (e.g. Preferences dialog). It's impossible for me to enumerate the changes. So this sim will need a full PhET-iO design review by @amanda-phet and @kathy-phet.

Hold off on this until #319 and other PhET-iO development work has been completed.

@pixelzoom
Copy link
Contributor Author

@amanda-phet @kathy-phet the portion of the design related to support for dynamic local (#319) is ready for review.

@pixelzoom
Copy link
Contributor Author

In 9/1/2022 design meeting, @kathy-phet said that design review should preceed migration rules #324. So this is ready for review.

@pixelzoom
Copy link
Contributor Author

Related to phetsims/tandem#267 ... Tandem names for all Text nodes now have a "Text" suffix, for example "labelText", "titleText". This is an API change. See above commits.

@zepumph
Copy link
Member

zepumph commented Sep 8, 2022

We looked here during PhET-iO meeting today to see where the progress currently was.

@arouinfar
Copy link

This simulation is not a current PhET-iO design priority, so unassigning.

@arouinfar
Copy link

I've completed my design review and identified only a few (mostly minor) issues which are tagged above. The remaining design work pertains to examples.md, which is being tracked in #346, so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants