Console errors when pressing Reset All after loading saved state

[Nancy-Salpepi]

Test device
MacBook Air (m1 chip)

Operating System
macOS 12.4

Browser
safari

Problem description
For phetsims/qa#818, after loading a saved state (from version 1.5 or version 1.4), pressing the Reset All button results in console errors. After a quick check, the sim seems to be working correctly after the errors appear.

Steps to reproduce

1. In Studio version 1.5.0-dev.1, select the Intro screen.
2. Open the console
3. Save the state (Feel free to make changes to the sim, but not necessary)
4. Load the saved state into Studio version 1.5.0-dev.1
5. Press the Reset All button

Visuals

[pixelzoom]

As with #310... This is (presumably) related to migration, a focus of this release. Assigning to @zepumph and @samreid.

[zepumph]

This is not specific to migration, you can also reproduce this by loading in a saved file from the same version. It is most likely a regression from phetsims/tandem#264. I'll take a look.

[zepumph]

Fixed above, since we were now doing disposal, we have to be less sloppy about our validation and error checking. @Nancy-Salpepi you should be able to confirm this is fixed on master, you can load the in the same old version standard phet-io wrapper (output from studio save button) as before. Feel free to close.

[Nancy-Salpepi]

Looks fixed @zepumph!
Closing

[pixelzoom]

@Nancy-Salpepi Sounds like you meant to close this issue, so I'll do so.