-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment radio buttons are re-enabled when you start sim and don't carry over when loaded #296
Comments
The relevant code is in EnvironmentPanel.js: // Simulation mode determines which UI components are enabled. unlink is not necessary.
model.simulationModeProperty.link( simulationMode => {
environmentRadioButtonGroup.enabledProperty.value = ( simulationMode !== SimulationMode.COMPLETED );
} ); The problem is that the sim controls So the options are: (1) Set (2) Remove the above code, so that the sim never changes If the instructional designer doesn't want the student to change the environment, then hiding the radio buttons seems more appropriate than disabling them. So my recommendation is option (1). This is a PhET-iO design issue, and the associated QA issue is top priority. So assigning to @amanda-phet with top priority. |
I agree with @pixelzoom . Option (1) is my preference. |
Option (1) has been implemented, patched in master and 1.4 branches. Ready for testing in the next 1.4 RC. |
Looks ok in rc.2 |
Device
Mac and Dell
OS
MacOS 11 and Win 10
Browser
Firefox and Chrome
Problem Description
For phetsims/qa#662. Seen with this element, but may happen with other elements as well. Seems similar to phetsims/gravity-and-orbits#394.
naturalSelection.introScreen.view.environmentPanel.environmentRadioButtonGroup.enabledProperty
When you disable the above element, pressing "Add a Mate" reenables the buttons, both in studio or a launched sim. In addition, if you save a sim with that element disabled, reenable it in studio, then "Load" that saved file, the property will not be disabled.
Visuals
The text was updated successfully, but these errors were encountered: