Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long screen names push navigation bar icon to the right when sim is launched #295

Closed
Tracked by #672
pixelzoom opened this issue Jul 1, 2021 · 4 comments
Closed
Tracked by #672
Labels
dev:phet-io type:bug Something isn't working

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 1, 2021

For phetsims/qa#662. phetsims/joist#725 is a problem in the natural-selection 1.4 branch. Blocking because it impacts usability of the navigation bar.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 6, 2021

Assigning to @jonathanolson, because he's responsible for the blocking issue phetsims/joist#725. Please let me know when this is fixed, and what I need to patch.

@pixelzoom pixelzoom assigned pixelzoom and unassigned jonathanolson Jul 13, 2021
pixelzoom added a commit that referenced this issue Jul 13, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 13, 2021

Cherry-picked the above shas, in order, without any problems.

Tested a local build using these steps:

  1. Lauch the sim in Studio
  2. Change the value of naturalSelection.introScreen.nameProperty to "Into The Spiderverse"
  3. Press the "Preview Sim" button. Verify that the screen name looks correct in the navbar and home screen.

Ready for testing in the next RC.

@KatieWoe
Copy link
Contributor

Looks good in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:phet-io type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants