-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing updates in Client Guides #268
Comments
Good catch. It looks like files in phet-io-client-guides/natural-selection were not updated after adding I've fixed client-requests.md in the above commits (@amanda-phet please review), and the revised tandems are:
It also looks like linked-property-example.png and studio-overview.png need to be revised, since they show the part of the Studio treee that has changed. I can't revise them because the assets used to create them are not checked in. (That appears to be general problem with all client guides, so I've created https://github.com/phetsims/phet-io-client-guides/issues/10 to resolve that.) @amanda-phet can you please revise these images with top priority? (This is blocking the PhET-iO team from commiting some work to master.) |
I created these updated assets. If it's ok for me to commit them to master I can do that, but I wasn't sure so just putting them here for @pixelzoom. |
I see the revised tandems as well. |
@amanda-phet The files that you've included in #268 (comment) have totally different than the dimensions of the files in GitHub. Their resolution is significantly lower. Does that matter? linked-property-example.png is 2880 x 1578, yours is 1531 x 840. |
@amanda-phet sent me another set of PNG files via Slack. The resolution is higher, but the dimensions are still off. She checked with @arouinfar, and "there is no scientific process for creating the screenshots". So we decided to go with these files, and I've commited them above. I tested by doing a local build, then inspecting the "PhET-iO Guide" and "Client Requests" links in the Wrapper Index. I didn't see any problems. I'll labeled this a ready for QA verification. |
To verify this issue:
|
Looks good in rc.1 |
For phetsims/qa#636. In client requests there is a request to hide the generation clock. But the instructions provided do not match anything in studio.
The text was updated successfully, but these errors were encountered: