Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing updates in Client Guides #268

Closed
KatieWoe opened this issue Apr 13, 2021 · 8 comments
Closed

Missing updates in Client Guides #268

KatieWoe opened this issue Apr 13, 2021 · 8 comments
Labels
type:bug Something isn't working

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#636. In client requests there is a request to hide the generation clock. But the instructions provided do not match anything in studio.
notinstudio

@KatieWoe KatieWoe added the type:bug Something isn't working label Apr 13, 2021
@KatieWoe
Copy link
Contributor Author

This also seems to happen for hiding the environmental buttons
visiblenotinstudio

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 13, 2021

Good catch.

It looks like files in phet-io-client-guides/natural-selection were not updated after adding environmentPanel to the tandem hierachy for for #263.

I've fixed client-requests.md in the above commits (@amanda-phet please review), and the revised tandems are:

naturalSelection.introScreen.view.environmentPanel.generationClockNode.visibleProperty
naturalSelection.labScreen.view.environmentPanel.generationClockNode.visibleProperty
naturalSelection.introScreen.view.environmentPanel.environmentRadioButtonGroup.visibleProperty
naturalSelection.labScreen.view.environmentPanel.environmentRadioButtonGroup.visibleProperty

It also looks like linked-property-example.png and studio-overview.png need to be revised, since they show the part of the Studio treee that has changed. I can't revise them because the assets used to create them are not checked in. (That appears to be general problem with all client guides, so I've created https://github.com/phetsims/phet-io-client-guides/issues/10 to resolve that.) @amanda-phet can you please revise these images with top priority? (This is blocking the PhET-iO team from commiting some work to master.)

@amanda-phet
Copy link
Contributor

I created these updated assets. If it's ok for me to commit them to master I can do that, but I wasn't sure so just putting them here for @pixelzoom.

linked-property-example
studio-overview

@amanda-phet
Copy link
Contributor

I see the revised tandems as well.

@amanda-phet amanda-phet removed their assignment Apr 13, 2021
@pixelzoom pixelzoom changed the title Client request to hide clock not in studio Missing updates in Client Guides Apr 13, 2021
@pixelzoom
Copy link
Contributor

@amanda-phet The files that you've included in #268 (comment) have totally different than the dimensions of the files in GitHub. Their resolution is significantly lower. Does that matter?

linked-property-example.png is 2880 x 1578, yours is 1531 x 840.
studio-overview.png is in the ballpark of 2720 x 1084 yours is 1872 x 752.

@pixelzoom
Copy link
Contributor

@amanda-phet sent me another set of PNG files via Slack. The resolution is higher, but the dimensions are still off. She checked with @arouinfar, and "there is no scientific process for creating the screenshots". So we decided to go with these files, and I've commited them above.

I tested by doing a local build, then inspecting the "PhET-iO Guide" and "Client Requests" links in the Wrapper Index. I didn't see any problems.

I'll labeled this a ready for QA verification.

@pixelzoom
Copy link
Contributor

To verify this issue:

@KatieWoe
Copy link
Contributor Author

Looks good in rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants