Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback wrapper slow or fails (macOS 10.15 + Chrome) #246

Closed
Tracked by #573
pixelzoom opened this issue Sep 24, 2020 · 12 comments
Closed
Tracked by #573

Playback wrapper slow or fails (macOS 10.15 + Chrome) #246

pixelzoom opened this issue Sep 24, 2020 · 12 comments

Comments

@pixelzoom
Copy link
Contributor

In phetsims/qa#551 (comment), @KatieWoe reported:

Playback wrapper seems to be exceedingly slow on Mac 10.15 Chrome for both loading log and starting playback. Having trouble even getting it to start. @zepumph please advise. In fact it seems to have timed out: Failed to load resource: net::ERR_CONNECTION_RESET

Blocks publication until someone decides otherwise.

@pixelzoom pixelzoom changed the title Playback wrapper slow or fails (Mac 10.5 Chrome) Playback wrapper slow or fails (Mac 10.15 Chrome) Sep 24, 2020
@pixelzoom pixelzoom changed the title Playback wrapper slow or fails (Mac 10.15 Chrome) Playback wrapper slow or fails (macOS 10.15 + Chrome) Sep 24, 2020
@zepumph
Copy link
Member

zepumph commented Sep 24, 2020

Partial duplicate-ish of https://github.com/phetsims/phet-io-wrappers/issues/376. I'm not sure about blocking. It would be nice to ask @kathy-phet during the phet-io meeting about the priority of the playback wrapper for NS.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Sep 24, 2020

From 9/24/2020 phet-io meeting over in https://github.com/phetsims/phet-io-wrappers/issues/376#issuecomment-698480693:

This should not block the current version of Natural Selection (1.2), but should still be high priority to look into. This will block the next version of NS though (the one that will be fully published). Marking as such.

We haven't seen this behavior outside of NS, but if we do, that will further up the priority on this.

So unblocking, and will be revisited after 1.2 release is out.

@zepumph
Copy link
Member

zepumph commented Sep 30, 2020

@pixelzoom, if you are planning to take shas from master for 1.3, this issue can be closed.

@zepumph
Copy link
Member

zepumph commented Sep 30, 2020

@pixelzoom
Copy link
Contributor Author

The next milestones (#251) will be taking shas from master. I'll label this as "fixed", and leave open for verification by QA.

@KatieWoe
Copy link
Contributor

KatieWoe commented Apr 6, 2021

This doesn't seem to happen anymore in dev.1. I did see phetsims/gravity-and-orbits#376. @pixelzoom up to you if you want to close.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 6, 2021

This doesn't seem to happen anymore in dev.1. I did see phetsims/gravity-and-orbits#376.

Is phetsims/gravity-and-orbits#376 significant here? Something that needs to be addressed for this sim? I have no idea.

@pixelzoom up to you if you want to close.

I'm not at all familiar with this feature, so I don't feel qualified to decide whether this is ready to close.

Assigning to the PhET-iO team to decide if phetsims/gravity-and-orbits#376 is significant here, and if this issue is ready to be closed.

@pixelzoom
Copy link
Contributor Author

For phetsims/qa/issues/636.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 12, 2021

@KatieWoe said:

This doesn't seem to happen anymore in dev.1. I did see phetsims/gravity-and-orbits#376.

To clarify, based on Slack discussion with @KatieWoe ... She no longer sees the problem reported here (Playback wrapper slow or fails). But she may see phetsims/gravity-and-orbits#376 occurring in NS now, but isn't certain.

I'm not clear on the differences between this issue (#246) and phetsims/gravity-and-orbits#376, so I'd like the PhET-iO team's recommendation on how to proceed. Can this issue be closed? Do we need a new issue for some aspect of phetsims/gravity-and-orbits#376 that is occurring with NS? Is any of this blocking?

@kathy-phet
Copy link

Playback wrapper needs general attention at some point when it becomes a priority for clients or researchers, but phetsims/gravity-and-orbits#376 is not a high priority and is not blocking for publication of NS.

@kathy-phet
Copy link

I'll make a central comment for playback wrapper.

@pixelzoom
Copy link
Contributor Author

Since @kathy-phet says that nothing here is blocking, I'm guessing that it's OK to close this issue. If someone disagrees, please reopen ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants