-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback wrapper slow or fails (macOS 10.15 + Chrome) #246
Comments
Partial duplicate-ish of https://github.com/phetsims/phet-io-wrappers/issues/376. I'm not sure about blocking. It would be nice to ask @kathy-phet during the phet-io meeting about the priority of the playback wrapper for NS. |
From 9/24/2020 phet-io meeting over in https://github.com/phetsims/phet-io-wrappers/issues/376#issuecomment-698480693:
So unblocking, and will be revisited after 1.2 release is out. |
@pixelzoom, if you are planning to take shas from master for 1.3, this issue can be closed. |
If we need to cherry-pick, see https://github.com/phetsims/phet-io-wrappers/issues/378#issuecomment-701665340 |
The next milestones (#251) will be taking shas from master. I'll label this as "fixed", and leave open for verification by QA. |
This doesn't seem to happen anymore in dev.1. I did see phetsims/gravity-and-orbits#376. @pixelzoom up to you if you want to close. |
Is phetsims/gravity-and-orbits#376 significant here? Something that needs to be addressed for this sim? I have no idea.
I'm not at all familiar with this feature, so I don't feel qualified to decide whether this is ready to close. Assigning to the PhET-iO team to decide if phetsims/gravity-and-orbits#376 is significant here, and if this issue is ready to be closed. |
@KatieWoe said:
To clarify, based on Slack discussion with @KatieWoe ... She no longer sees the problem reported here (Playback wrapper slow or fails). But she may see phetsims/gravity-and-orbits#376 occurring in NS now, but isn't certain. I'm not clear on the differences between this issue (#246) and phetsims/gravity-and-orbits#376, so I'd like the PhET-iO team's recommendation on how to proceed. Can this issue be closed? Do we need a new issue for some aspect of phetsims/gravity-and-orbits#376 that is occurring with NS? Is any of this blocking? |
Playback wrapper needs general attention at some point when it becomes a priority for clients or researchers, but phetsims/gravity-and-orbits#376 is not a high priority and is not blocking for publication of NS. |
I'll make a central comment for playback wrapper. |
Since @kathy-phet says that nothing here is blocking, I'm guessing that it's OK to close this issue. If someone disagrees, please reopen ASAP. |
In phetsims/qa#551 (comment), @KatieWoe reported:
Blocks publication until someone decides otherwise.
The text was updated successfully, but these errors were encountered: