-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
populationPanel.visibleProperty mistakenly not featured #236
Comments
I discussed with @amanda-phet on Slack. Faster for me to do this in master and 1.2, and I'll have @amanda-phet review master. |
Actually a good thing that I did this. Because I'm using WebStorm, I discovered that overrides.js formatting does not match PhET style, https://github.com/phetsims/studio/issues/196. |
Addressed in master and 1.2 by the above commits. @amanda-phet please review in master. If it looks OK, assign back to me. |
Looks good. As for phetsims/studio#196, do we need to do something with the formatting when we paste into overrides? Or can we keep doing what we are doing? |
Best to ask that in phetsims/studio#196. I'll move your question there. |
Ready for testing in the next 1.2 RC. Verify on 1 platform, using these steps:
|
This does look fixed in rc.2 |
@KatieWoe noticed in phetsims/qa#551 that an element that was supposed to be featured was not.
I'll feature
naturalSelection.labScreen.view.graphs.populationNode.populationPanel.visibleProperty
in master, then @pixelzoom will patch the 1.2 branch.The text was updated successfully, but these errors were encountered: