Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populationPanel.visibleProperty mistakenly not featured #236

Closed
amanda-phet opened this issue Sep 22, 2020 · 7 comments
Closed

populationPanel.visibleProperty mistakenly not featured #236

amanda-phet opened this issue Sep 22, 2020 · 7 comments
Labels
design:phet-io type:bug Something isn't working

Comments

@amanda-phet
Copy link
Contributor

@KatieWoe noticed in phetsims/qa#551 that an element that was supposed to be featured was not.

I'll feature naturalSelection.labScreen.view.graphs.populationNode.populationPanel.visibleProperty in master, then @pixelzoom will patch the 1.2 branch.

@amanda-phet amanda-phet self-assigned this Sep 22, 2020
@pixelzoom
Copy link
Contributor

I discussed with @amanda-phet on Slack. Faster for me to do this in master and 1.2, and I'll have @amanda-phet review master.

@pixelzoom pixelzoom assigned pixelzoom and unassigned amanda-phet Sep 22, 2020
@pixelzoom pixelzoom added design:phet-io type:bug Something isn't working labels Sep 22, 2020
@pixelzoom
Copy link
Contributor

Actually a good thing that I did this. Because I'm using WebStorm, I discovered that overrides.js formatting does not match PhET style, https://github.com/phetsims/studio/issues/196.

pixelzoom added a commit that referenced this issue Sep 22, 2020
pixelzoom added a commit that referenced this issue Sep 22, 2020
@pixelzoom
Copy link
Contributor

Addressed in master and 1.2 by the above commits. @amanda-phet please review in master. If it looks OK, assign back to me.

@amanda-phet
Copy link
Contributor Author

Looks good.

As for phetsims/studio#196, do we need to do something with the formatting when we paste into overrides? Or can we keep doing what we are doing?

@amanda-phet amanda-phet assigned pixelzoom and unassigned amanda-phet Sep 23, 2020
@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 24, 2020

As for phetsims/studio#196, do we need to do something with the formatting when we paste into overrides? Or can we keep doing what we are doing?

Best to ask that in phetsims/studio#196. I'll move your question there.

@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 24, 2020

Ready for testing in the next 1.2 RC.

Verify on 1 platform, using these steps:

  1. Open the sim in Studio
  2. Search for naturalSelection.labScreen.view.graphs.populationNode.populationPanel.visibleProperty, and confirm that it is featured.

@KatieWoe
Copy link
Contributor

This does look fixed in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:phet-io type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants