Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoL may put up dialogs after pause #215

Closed
KatieWoe opened this issue Sep 1, 2020 · 2 comments
Closed

LoL may put up dialogs after pause #215

KatieWoe opened this issue Sep 1, 2020 · 2 comments
Assignees
Labels
type:wontfix This will not be worked on

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Sep 1, 2020

For phetsims/qa#542. Very minor, easier to see on a slower device like Lovelace ChromeOS.
If you click pause on LoL during the pause before a dialog comes up, but before it has loaded, then the sim will pause, and the dialog will appear while paused.
Steps:

  1. Go to either screen.
  2. Add a mate
  3. Be ready to pause using harness
  4. As the 5th gen finishes, pause before the dialog for bunnies taking over comes up.

Can be hard to reproduce, especially on fast devices.

@KatieWoe KatieWoe added the type:bug Something isn't working label Sep 1, 2020
@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 1, 2020

No idea why someone would even want to do this. But I don't know anything about how sims are used by LoL.

When the 5th generation completes, and the sim pauses normally (not LoL pauses it), the dialog has already been schedule to be displayed. And you can't stop work that's already been scheduled as part of the current frame. My guess is that on the Chromebook, you're just getting lucky and pressing LoL "Pause" before the sim has normally paused and the dialog has been scheduled.

My recommendation is to close this as "won't fix", but I'll let @ariel-phet decide.

@pixelzoom pixelzoom removed their assignment Sep 1, 2020
@pixelzoom pixelzoom removed the type:bug Something isn't working label Sep 1, 2020
@ariel-phet ariel-phet added the type:wontfix This will not be worked on label Sep 1, 2020
@ariel-phet
Copy link

@KatieWoe certainly appreciate the diligence in finding this situation, but I agree, this seems unlikely to be an issue. Marking as wontfix and closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants