Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leak in Tandem.removePhetioObject #205

Closed
pixelzoom opened this issue Aug 25, 2020 · 2 comments
Closed

memory leak in Tandem.removePhetioObject #205

pixelzoom opened this issue Aug 25, 2020 · 2 comments
Assignees
@pixelzoom
Labels
dev:phet-io status:blocks-sim-publication type:bug Something isn't working

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 25, 2020 •
edited
Loading

See phetsims/tandem#203. Since this leaks memory in brand=phet, this blocks publication of the prototype.

Also a pre-requisite for resolving: #189, #190
This was referenced Aug 25, 2020
Closed
Closed
@pixelzoom
Copy link
Contributor Author

phetsims/tandem#203 is fixed and ready for testing in natural-selection, see phetsims/tandem#203 (comment).

@pixelzoom pixelzoom self-assigned this Aug 27, 2020
@pixelzoom
Copy link
Contributor Author

Memory tests look good for both NS brands, see #189 and #190. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io status:blocks-sim-publication type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom