-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory test for brand=phet-io (1.1 branch) #190
Comments
On hold until the memory leaks identified in |
Some big iO memory leaks were identified for brand=phet, see #189 (comment). So it's time to see what the state of I'll be using the same test procedure described in #189 (comment), but running with |
Test results with local unbuilt, natural-selection sha e32a316, with the patches from phetsims/tandem#203 and phetsims/axon#328 applied. Test configuration: 2019 MacBook Pro (MacBookPro16,1), macOS 10.15.6, Chrome 84.0.4147.135
This looks nice. With a stable population, the footprint is immediately stable at ~60MB. It was 45BM for brand=phet in #189 (comment), so there's not a huge increase for brand=phet-io. And the Generation 0 population is fairly consistent. Work is done here. On hold until phetsims/tandem#203 and phetsims/axon#328 are addressed. Then I will sanity check with one more test. |
After fixes for phetsims/tandem#203 and phetsims/axon#328 were pushed... Testing results on 2019 MacBook Pro, macOS 10.15.6, Chrome 85.0.4183.83 (Incognito), with https://phet-dev.colorado.edu/html/natural-selection/1.1.0-dev.17/phet-io/natural-selection_all_phet-io.html?postMessageOnError&phetioStandalone&secondsPerGeneration=0.25
This looks great. Stable memory with stable population, consistent memory for Generation 0. And ~24% more memory than brand=phet (~45MB vs ~56MB), see #189 (comment). Closing. |
This is one of the "standard GitHub issues" required by the code-review checklist.
The text was updated successfully, but these errors were encountered: