Skip to content

Commit

Permalink
Rename textProperty => stringProperty, see phetsims/scenery#1451
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Sep 16, 2022
1 parent 7d27b43 commit e6a9cb9
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions js/common/view/AddMutationsPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -413,18 +413,18 @@ class TitleNode extends Text {
tandem: Tandem.REQUIRED
}, options );

const textProperty = new DerivedProperty( [
const stringProperty = new DerivedProperty( [
numberOfRowsVisibleProperty,
NaturalSelectionStrings.addMutationStringProperty,
NaturalSelectionStrings.addMutationsStringProperty
],
( numberOfRowsVisible, addMutationString, addMutationsString ) =>
( numberOfRowsVisible === 1 ) ? addMutationString : addMutationsString, {
tandem: options.tandem.createTandem( 'textProperty' ),
tandem: options.tandem.createTandem( 'stringProperty' ),
phetioValueType: StringIO
} );

super( textProperty, options );
super( stringProperty, options );
}

/**
Expand Down
6 changes: 3 additions & 3 deletions js/common/view/EnvironmentalFactorsPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,17 @@ class TitleNode extends Text {
tandem: Tandem.REQUIRED
}, options );

const textProperty = new DerivedProperty( [
const stringProperty = new DerivedProperty( [
numberOfCheckboxesVisibleProperty,
NaturalSelectionStrings.environmentalFactorStringProperty,
NaturalSelectionStrings.environmentalFactorsStringProperty
], ( numberOfCheckboxesVisible, environmentalFactor, environmentalFactors ) =>
( numberOfCheckboxesVisible === 1 ) ? environmentalFactor : environmentalFactors, {
tandem: options.tandem.createTandem( 'textProperty' ),
tandem: options.tandem.createTandem( 'stringProperty' ),
phetioValueType: StringIO
} );

super( textProperty, options );
super( stringProperty, options );
}

/**
Expand Down
2 changes: 1 addition & 1 deletion js/common/view/GenerationClockNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class GenerationClockNode extends Node {
const generationDerivedStringProperty = new PatternStringProperty( NaturalSelectionStrings.generationValueStringProperty, {
value: generationClock.clockGenerationProperty
}, {
tandem: generationNumberTextTandem.createTandem( 'textProperty' ),
tandem: generationNumberTextTandem.createTandem( 'stringProperty' ),
phetioValueType: StringIO
} );
const generationNumberText = new Text( generationDerivedStringProperty, {
Expand Down
4 changes: 2 additions & 2 deletions js/common/view/proportions/ProportionsGraphNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class ProportionsGraphNode extends Node {
NaturalSelectionStrings.endOfGenerationStringProperty
], ( isDisplayingCurrentGeneration, currentlyString, endOfGenerationString ) =>
isDisplayingCurrentGeneration ? currentlyString : endOfGenerationString, {
tandem: endRowLabelTandem.createTandem( 'textProperty' ),
tandem: endRowLabelTandem.createTandem( 'stringProperty' ),
phetioValueType: StringIO
} );
const endRowLabel = new RowLabel( endRowTopTextDerivedProperty, endCounts.totalCount, {
Expand Down Expand Up @@ -291,7 +291,7 @@ class RowLabel extends VBox {
NaturalSelectionStrings.countBunniesStringProperty
], ( count, oneBunnyString, countBunniesString ) =>
( count === 1 ) ? oneBunnyString : StringUtils.fillIn( countBunniesString, { count: count } ), {
tandem: secondLineOfTextTandem.createTandem( 'textProperty' ),
tandem: secondLineOfTextTandem.createTandem( 'stringProperty' ),
phetioValueType: StringIO
} );
const secondLineOfText = new Text( secondLineOfTextDerivedStringProperty, merge( {
Expand Down

0 comments on commit e6a9cb9

Please sign in to comment.