-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart button not working correctly in launched sim #327
Comments
Pushed a possible fix using a workaround of isSettingPhetioState. @pixelzoom could you please review the above commit? I feel like there might be a more elegant and phet-io-y way to achieve the same effect. If it looks good, could you assign to @Nancy-Salpepi for QA review and then cherry picking? |
Nevermind, this breaks the restart button in the state wrapper (upsteam restarts to the default position whereas downstream goes to the current one). Will keep looking. |
I believe one reason this may happen is that, in the sim in studio before it is launched the restart button goes back to that starting position which is correct in that version of the sim. When launched the restart button still points to that position. |
After talking with @arouinfar and @pixelzoom it seems the fix was indeed working for state wrapper. I pushed a little improvement and it's now ready for review and then cherry pick! |
This looks good now in State/Studio wrappers. |
I'd say it's okay to have it enabled since there is a "history" of the sim when you launch it (the paths). With the restart button they disappear and T goes back to 0. |
(cherry picked from commit 4a70c3a)
(cherry picked from commit 348628c)
This looks good in rc.4 |
Test device
MacBook Air M1 chip
Operating System
14.1.2
Browser
Chrome
Problem description
For phetsims/qa#1015, in Studio and State Wrappers, pressing the Restart button in the launched sim doesn't return the sim to its launched state.
From Amy on Slack:
Amy Rouinfar
1:51 PM
Steps to reproduce
Visuals
Video starts after pressing Test in Studio (It takes too long for the standard wrapper to open)
RestartButton.mp4
The text was updated successfully, but these errors were encountered: