Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer able to press and hold Step Forward button #321

Closed
Tracked by #1029
Nancy-Salpepi opened this issue Dec 19, 2023 · 5 comments
Closed
Tracked by #1029

No longer able to press and hold Step Forward button #321

Nancy-Salpepi opened this issue Dec 19, 2023 · 5 comments
Assignees
@AgustinVallejo
Labels
status:fixed-awaiting-deploy type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.1.2

Browser
Chrome

Problem description
For phetsims/qa#1015, I am no longer able to press and hold the Step Forward button with my mouse on either screen. Works just fine in 1.3.0-dev.7.
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Dec 19, 2023
AgustinVallejo added a commit to phetsims/solar-system-common that referenced this issue Dec 20, 2023
@AgustinVallejo
Addressing when to interrupt everything or when to interrupt only the…
6d31959 
… bodies, see phetsims/my-solar-system#321
AgustinVallejo added a commit that referenced this issue Dec 20, 2023
@AgustinVallejo
Addressing when to interrupt everything or when to interrupt only the…
522a99a 
… bodies, see #321
@AgustinVallejo
Copy link
Contributor

The above changes fix this, please review @Nancy-Salpepi and assign back to me for cherry picking if done.

@Nancy-Salpepi
Copy link
Author

This is still broken.

AgustinVallejo added a commit to phetsims/solar-system-common that referenced this issue Dec 20, 2023
@AgustinVallejo
Interrupting only bodies subtree with step button, see phetsims/my-so…
4b7f726 
…lar-system#321
@AgustinVallejo
Copy link
Contributor

Weird, it seems I didn't commit a part of this solution. Sorry for that, please review again.

@Nancy-Salpepi
Copy link
Author

OK. Looks good now. Ready to 🍒pick.

AgustinVallejo added a commit that referenced this issue Jan 10, 2024
@AgustinVallejo
Addressing when to interrupt everything or when to interrupt only the…
9286d65 
… bodies, see #321

(cherry picked from commit 522a99a)
AgustinVallejo added a commit to phetsims/solar-system-common that referenced this issue Jan 10, 2024
@AgustinVallejo
Addressing when to interrupt everything or when to interrupt only the…
0581add 
… bodies, see phetsims/my-solar-system#321

(cherry picked from commit 6d31959)
AgustinVallejo added a commit to phetsims/solar-system-common that referenced this issue Jan 10, 2024
@AgustinVallejo
Interrupting only bodies subtree with step button, see phetsims/my-so…
45b9602 
…lar-system#321

(cherry picked from commit 4b7f726)
@AgustinVallejo AgustinVallejo mentioned this issue Jan 10, 2024
Closed
21 tasks
@Nancy-Salpepi
Copy link
Author

This looks good in rc.4
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
status:fixed-awaiting-deploy type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @AgustinVallejo @Nancy-Salpepi