Inline COMBO_BOX_TEXT_OPTIONS in MySolarSystemComboBox, see #88

phetsims · Mar 10, 2023 · 35a257b · 35a257b
1 parent 85a1489
commit 35a257b
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/js/common/view/MySolarSystemComboBox.ts b/js/common/view/MySolarSystemComboBox.ts
@@ -18,12 +18,6 @@ import MySolarSystemStrings from '../../MySolarSystemStrings.js';
 import MySolarSystemModel from '../model/MySolarSystemModel.js';
 import { Node, Text } from '../../../../scenery/js/imports.js';
 
-//REVIEW: This is only used once, why not inline it?
-const COMBO_BOX_TEXT_OPTIONS = {
-  font: SolarSystemCommonConstants.PANEL_FONT,
-  maxWidth: SolarSystemCommonConstants.MAX_WIDTH
-};
-
 export default class MySolarSystemComboBox extends ComboBox<LabMode> {
   public constructor( model: MySolarSystemModel, listParent: Node ) {
 
@@ -76,7 +70,10 @@ export default class MySolarSystemComboBox extends ComboBox<LabMode> {
       const nameProperty = modeNameMap.get( mode )!;
       return {
         value: mode,
-        createNode: () => new Text( nameProperty, COMBO_BOX_TEXT_OPTIONS ),
+        createNode: () => new Text( nameProperty, {
+          font: SolarSystemCommonConstants.PANEL_FONT,
+          maxWidth: SolarSystemCommonConstants.MAX_WIDTH
+        } ),
         a11yName: nameProperty
       };
     };