-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sounds to play/pause/step hotkeys #339
Comments
|
These have been added, and you made it very easy for me! @jbphet and @terracoda can you please review? |
I've reviewed the code, and it looks reasonable to me. @terracoda - I'll leave it to you to verify that the behavior is what we're after. |
From my "non-visual screen reader" perspective this ALT + L interaction is really awesome - much preferred to the default Step Forward. The sounds sound great to me and the number of steps across the Observation Window seem really good. I don't know what JAWS and NVDA will say with each ALT + L key press, but VO does not mention the actual keys on key presses. With VO, if nothing is happening, I just hear the Step Forward UI sound which makes for a really nice experience. Then when something is happening, I hear the step forward UI sound on each step and the occasional context response about photons (every 4 to 8 steps). Then when a vibration is happening, I get the UI sound and a context response on every key press during the vibration. It sounds really nice to me. I think we can close this issue. |
No description provided.
The text was updated successfully, but these errors were encountered: