Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sounds to play/pause/step hotkeys #339

Closed
jessegreenberg opened this issue May 8, 2020 · 4 comments
Closed

Add sounds to play/pause/step hotkeys #339

jessegreenberg opened this issue May 8, 2020 · 4 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

No description provided.

@jessegreenberg jessegreenberg self-assigned this May 8, 2020
@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented May 8, 2020

From #336
@jbphet said

There are a set of singleton sound instances that can be included in the appropriate file that should, I think, make this pretty straightforward. Please have a look at playSoundPlayer, pauseSoundPlayer, and stepForwardSoundPlayer, as well as their usages in the code base, and go from there. I'm always available to consult if needed.

@jessegreenberg
Copy link
Contributor Author

These have been added, and you made it very easy for me! @jbphet and @terracoda can you please review?

@jbphet
Copy link
Contributor

jbphet commented May 11, 2020

I've reviewed the code, and it looks reasonable to me. @terracoda - I'll leave it to you to verify that the behavior is what we're after.

@jbphet jbphet removed their assignment May 11, 2020
@terracoda
Copy link

From my "non-visual screen reader" perspective this ALT + L interaction is really awesome - much preferred to the default Step Forward.

The sounds sound great to me and the number of steps across the Observation Window seem really good.

I don't know what JAWS and NVDA will say with each ALT + L key press, but VO does not mention the actual keys on key presses. With VO, if nothing is happening, I just hear the Step Forward UI sound which makes for a really nice experience. Then when something is happening, I hear the step forward UI sound on each step and the occasional context response about photons (every 4 to 8 steps). Then when a vibration is happening, I get the UI sound and a context response on every key press during the vibration. It sounds really nice to me.

I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants