-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long molecule responses: Shorten delay and repeat long response on every third response #228
Comments
This is technically possible, but the delay was initially added to prevent a long queue up of alerts after the screen reader reads aria-valuetext/radio button responses, not to make sure they are always spoken. So if we do this we will still have that problem. |
Im going to look at utteranceQueue and see if there is a better workaround that doesn't use a delay. |
So a couple of thoughts:
Before adding the (somewhat complicated) code for idea 2 above, I want to check and see if curent behavior is sufficient. |
Delay removed for now in the above commit. |
@terracoda @Matthew-phet here is a new version with this. Can you please try and see how alerts appear in this version and determine if any further work is necessary? |
The alerts are all firing nicely with no delay on VoiceOver. |
I still think it may be beneficial to repeat longer responses occasionally. I think this would enhance the current experience. We can discuss at design meeting, though. As it is working right now (at least on my machine) the experience is nice enough for getting feedback from screen reader users. |
We have had feedback from at least 3 interview participants that the amount of description in the normal-speed responses is good. There is no need to repeat the longer response at regular intervals. Closing this issue. |
The current delay observed in 1.5.0-dev.18 does make it so we hear the longer molecule response at least once, most of the time.
After playing with the sim, @Matthew-phet and @terracoda think that a better approach might be to have a shorter delay (possibly even no delay) and then repeat the long version of the response on every third molecule reaction.
There seems to be time and it seems a bit more interactive to us.
@jessegreenberg, is that kind of repeated pattern doable?
If so, please implement. If not, please provide your thoughts on the matter.
The text was updated successfully, but these errors were encountered: