Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long molecule responses: Shorten delay and repeat long response on every third response #228

Closed
terracoda opened this issue Dec 6, 2019 · 8 comments
Assignees

Comments

@terracoda
Copy link

The current delay observed in 1.5.0-dev.18 does make it so we hear the longer molecule response at least once, most of the time.

After playing with the sim, @Matthew-phet and @terracoda think that a better approach might be to have a shorter delay (possibly even no delay) and then repeat the long version of the response on every third molecule reaction.

There seems to be time and it seems a bit more interactive to us.

@jessegreenberg, is that kind of repeated pattern doable?
If so, please implement. If not, please provide your thoughts on the matter.

@jessegreenberg
Copy link
Contributor

This is technically possible, but the delay was initially added to prevent a long queue up of alerts after the screen reader reads aria-valuetext/radio button responses, not to make sure they are always spoken. So if we do this we will still have that problem.

@jessegreenberg
Copy link
Contributor

Im going to look at utteranceQueue and see if there is a better workaround that doesn't use a delay.

@jessegreenberg
Copy link
Contributor

So a couple of thoughts:

  • Now that Molecule Alerts getting interrupted #225 is fixed, we no long hear "document, document" every time a radio button is selected. So there is less AT talking time before we say an alert. And when I remove the delay entirely we get a pretty good representation of what happens visually now.
  • I thought of a another solution to let the screen reader "catch up" on alerts. After selecting a new radio button, we speak the long alert right when it happens. Then we add a delay before the first SHORT alert and don't alert until the end of this delay. I tried it out and it sounds pretty good. The implication is that we may miss one or two short "bending" alerts, but the screen reader is still talking at this time so I think that is OK.

Before adding the (somewhat complicated) code for idea 2 above, I want to check and see if curent behavior is sufficient.

@jessegreenberg
Copy link
Contributor

Delay removed for now in the above commit.

@jessegreenberg
Copy link
Contributor

@terracoda @Matthew-phet here is a new version with this. Can you please try and see how alerts appear in this version and determine if any further work is necessary?

https://phet-dev.colorado.edu/html/molecules-and-light/1.5.0-dev.19/phet/molecules-and-light_en_phet.html?a11y&supportsSound

@terracoda
Copy link
Author

The alerts are all firing nicely with no delay on VoiceOver.
VoiceOver stops announcing responses from time to time but that is a known bug and you just needs to restart VoiceOver to get them going again.

@terracoda
Copy link
Author

I still think it may be beneficial to repeat longer responses occasionally. I think this would enhance the current experience. We can discuss at design meeting, though.

As it is working right now (at least on my machine) the experience is nice enough for getting feedback from screen reader users.

@terracoda
Copy link
Author

We have had feedback from at least 3 interview participants that the amount of description in the normal-speed responses is good.

There is no need to repeat the longer response at regular intervals.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants