Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basics: realMoleculeShapesProperty includes values that are only valid in the full version #227

Closed
Tracked by #237
arouinfar opened this issue Oct 7, 2022 · 3 comments

Comments

@arouinfar
Copy link
Contributor

Related to #223

The valid values of realMoleculeShapesProperty seems to be the full list of molecules available in Molecule Shapes. If you pass in a value that only appears in Molecule Shapes, Studio will not stop you.

For example, set the value to SF4 and it will appear to work, but the sim encounters a fatal error and freezes.
image

@jonathanolson should the validation be limited to the 5 molecules in Molecule Shapes: Basics?

@arouinfar
Copy link
Contributor Author

arouinfar commented Oct 20, 2022

Tagging for phetsims/qa#845.

@zepumph
Copy link
Member

zepumph commented Dec 8, 2022

I was able to get this done by having the Property get validValues to start with. @arouinfar how does that look?

@arouinfar
Copy link
Contributor Author

Thanks @zepumph! Everything looks good in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants