Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many credits gone #204

Closed
Tracked by #768
KatieWoe opened this issue Nov 29, 2021 · 7 comments
Closed
Tracked by #768

Many credits gone #204

KatieWoe opened this issue Nov 29, 2021 · 7 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#745.
Most of the credits in the About section seem to be gone. Compare to V. 1.2, which is currently published.

Visuals
12credits

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Molecule Shapes‬
URL: https://phet-dev.colorado.edu/html/molecule-shapes/1.4.0-rc.1/phet/molecule-shapes_all_phet.html?showPointerAreas
Version: 1.4.0-rc.1 2021-11-24 02:29:02 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36
Language: en-US
Window: 1280x649
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe
Copy link
Contributor Author

Also seems to occur on basics

arouinfar added a commit that referenced this issue Dec 3, 2021
arouinfar added a commit that referenced this issue Dec 3, 2021
@arouinfar
Copy link
Contributor

Really great find @KatieWoe. Looks like the credits were updated in April 2019 in these commits 5b6acdd and d5b3ea6, but they were only applied to the 1.2 branch, not master.

@jonathanolson I went ahead and fixed the credits in master and 1.4 in the above commits, including QA testers for the current RC cycle.

arouinfar added a commit to phetsims/molecule-shapes-basics that referenced this issue Dec 3, 2021
arouinfar added a commit to phetsims/molecule-shapes-basics that referenced this issue Dec 3, 2021
@arouinfar
Copy link
Contributor

I updated the credits in Basics in the above commits.

@jonathanolson
Copy link
Contributor

Thanks! Branches and master looks good, unassigning and marking for review for next RC (presumably)

@KatieWoe
Copy link
Contributor Author

Looks fixed in the new dev tests. Please add Brooklyn Lash to the QA credits as well.

jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue Jan 26, 2022
jonathanolson added a commit that referenced this issue Jan 26, 2022
@jonathanolson
Copy link
Contributor

Added in master. Everything look good here?

@KatieWoe
Copy link
Contributor Author

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants