-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many credits gone #204
Comments
Also seems to occur on basics |
Really great find @KatieWoe. Looks like the credits were updated in April 2019 in these commits 5b6acdd and d5b3ea6, but they were only applied to the 1.2 branch, not master. @jonathanolson I went ahead and fixed the credits in master and 1.4 in the above commits, including QA testers for the current RC cycle. |
I updated the credits in Basics in the above commits. |
Thanks! Branches and master looks good, unassigning and marking for review for next RC (presumably) |
Looks fixed in the new dev tests. Please add Brooklyn Lash to the QA credits as well. |
Added in master. Everything look good here? |
Looks good |
Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#745.
Most of the credits in the About section seem to be gone. Compare to V. 1.2, which is currently published.
Visuals
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: Molecule Shapes
URL: https://phet-dev.colorado.edu/html/molecule-shapes/1.4.0-rc.1/phet/molecule-shapes_all_phet.html?showPointerAreas
Version: 1.4.0-rc.1 2021-11-24 02:29:02 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36
Language: en-US
Window: 1280x649
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: